Skip to content

Fix incorrect URI resolution when root schema $id is not an absolute URI #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

OptimumCode
Copy link
Owner

Resolves #87

@OptimumCode OptimumCode added the fix Fix for bug label Mar 15, 2024
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.43%. Comparing base (ed1a780) to head (fcd0248).

Files Patch % Lines
...b/optimumcode/json/schema/internal/SchemaLoader.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   91.46%   91.43%   -0.04%     
==========================================
  Files         104      104              
  Lines        2356     2358       +2     
  Branches      603      604       +1     
==========================================
+ Hits         2155     2156       +1     
  Misses         36       36              
- Partials      165      166       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OptimumCode OptimumCode enabled auto-merge (squash) March 15, 2024 17:04
@OptimumCode OptimumCode merged commit 11eb889 into main Mar 15, 2024
@OptimumCode OptimumCode deleted the issue_#87 branch March 15, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: uri-reference in root $id results in incorrect reference resolution
1 participant