Skip to content

Commit 170a79a

Browse files
committed
Fingers crossed this will be the last tweak...
1 parent 1ebb5fd commit 170a79a

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

.github/workflows/test.yml

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,10 @@ jobs:
9696
# Skip test runs on builds which are also run in the coverage job.
9797
# Note: the tests on PHP 7.2 will still be run as the coverage build uses custom_ini settings for that version.
9898
- php: '5.4'
99+
os: 'ubuntu-latest'
100+
skip_tests: true
101+
- php: '5.4'
102+
os: 'windows-latest'
99103
skip_tests: true
100104
- php: '8.4'
101105
skip_tests: true
@@ -200,10 +204,22 @@ jobs:
200204
strategy:
201205
matrix:
202206
os: ['ubuntu-latest', 'windows-latest']
203-
php: ['5.4', '8.4']
207+
php: ['8.4']
204208
custom_ini: [false]
205209

206210
include:
211+
- php: '5.4'
212+
os: 'ubuntu-latest'
213+
custom_ini: false
214+
# Installing on Windows with PHP 5.4 runs into all sorts of problems with Composer.
215+
# Considering PHP 5.4 is ancient, I deem it acceptable to run coverage on Windows on PHP 5.5.
216+
# See this issue for more context (yes, I've seen this problem before):
217+
# @link https://github.com/PHPCSStandards/composer-installer/pull/213
218+
- php: '5.5'
219+
os: 'windows-latest'
220+
custom_ini: false
221+
222+
# Also run one coverage build with custom ini settings.
207223
- php: '7.2'
208224
os: 'ubuntu-latest'
209225
custom_ini: true

0 commit comments

Comments
 (0)