Skip to content

Commit 2000a32

Browse files
rodrigoprimojrfnl
authored andcommitted
Generic/DisallowLongArraySyntax: remove unreachable condition
A check was added to the top of the file in 8d2a9dd to return an error early if the array is missing an opening and/or a closing parenthesis. This means that `$opener` can never be null as when the code reaches the point where this variable is set, `$tokens[$stackPtr]['parenthesis_opener']` cannot be null.
1 parent 8c09939 commit 2000a32

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

src/Standards/Generic/Sniffs/Arrays/DisallowLongArraySyntaxSniff.php

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,9 @@ public function process(File $phpcsFile, $stackPtr)
5959

6060
$phpcsFile->fixer->beginChangeset();
6161

62-
if ($opener === null) {
63-
$phpcsFile->fixer->replaceToken($stackPtr, '[]');
64-
} else {
65-
$phpcsFile->fixer->replaceToken($stackPtr, '');
66-
$phpcsFile->fixer->replaceToken($opener, '[');
67-
$phpcsFile->fixer->replaceToken($closer, ']');
68-
}
62+
$phpcsFile->fixer->replaceToken($stackPtr, '');
63+
$phpcsFile->fixer->replaceToken($opener, '[');
64+
$phpcsFile->fixer->replaceToken($closer, ']');
6965

7066
$phpcsFile->fixer->endChangeset();
7167
}

0 commit comments

Comments
 (0)