Skip to content

Commit 2c32a6e

Browse files
committed
Tests/StableCommentWhitespace[Win]Test: use named data sets
With non-named data sets, when a test fails, PHPUnit will display the number of the test which failed. With tests which have a _lot_ of data sets, this makes it _interesting_ (and time-consuming) to debug those, as one now has to figure out which of the data sets in the data provider corresponds to that number. Using named data sets makes debugging failing tests more straight forward as PHPUnit will display the data set name instead of the number. Using named data sets also documents what exactly each data set is testing. Aside from adding the data set name, this commit also adds the parameter name for each item in the data set, this time in an effort to make it more straight forward to update and add tests as it will be more obvious what each key in the data set signifies. Includes making the data types in the docblocks more specific.
1 parent 6b8e591 commit 2c32a6e

File tree

2 files changed

+141
-141
lines changed

2 files changed

+141
-141
lines changed

0 commit comments

Comments
 (0)