Merge pull request #438 from PHPCSStandards/feature/cs-don't-join

CS: use `implode()` not `join()`

Author: jrfnl

src/Standards/Generic/Sniffs/CodeAnalysis/JumbledIncrementerSniff.php

@@ -89,7 +89,7 @@ public function process(File $phpcsFile, $stackPtr)
 
             if (count($diff) !== 0) {
                 $error = 'Loop incrementor (%s) jumbling with inner loop';
-                $data  = [join(', ', $diff)];
+                $data  = [implode(', ', $diff)];
                 $phpcsFile->addWarning($error, $stackPtr, 'Found', $data);
             }
         }

src/Standards/Squiz/Sniffs/Debug/JavaScriptLintSniff.php

@@ -67,7 +67,7 @@ public function process(File $phpcsFile, $stackPtr)
         // provide useful error reporting.
         if ($retval === 2 || $retval === 4) {
             if (is_array($output) === true) {
-                $msg = join('\n', $output);
+                $msg = implode('\n', $output);
             }
 
             throw new RuntimeException("Failed invoking JavaScript Lint, retval was [$retval], output was [$msg]");

src/Standards/Zend/Sniffs/Debug/CodeAnalyzerSniff.php

@@ -69,7 +69,7 @@ public function process(File $phpcsFile, $stackPtr)
         // provide useful error reporting.
         if (is_numeric($exitCode) === true && $exitCode > 0) {
             if (is_array($output) === true) {
-                $msg = join('\n', $output);
+                $msg = implode('\n', $output);
             }
 
             throw new RuntimeException("Failed invoking ZendCodeAnalyzer, exitcode was [$exitCode], retval was [$retval], output was [$msg]");