Skip to content

Commit 3ae055e

Browse files
committed
Add links to all issues in the 3.5.3 and 3.5.2 sections of the changelog
This commit also fixes a few typos in the two changelogs.
1 parent 45c61f5 commit 3ae055e

File tree

1 file changed

+35
-18
lines changed

1 file changed

+35
-18
lines changed

CHANGELOG.md

Lines changed: 35 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1084,7 +1084,7 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
10841084
- The double arrow becomes the scope opener, and uses a new T_FN_ARROW token type
10851085
- The token after the statement (normally a semicolon) becomes the scope closer
10861086
- The token is also associated with the opening and closing parenthesis of the statement
1087-
- Any functions named "fn" will cause have a T_FN token for the function name, but have no scope information
1087+
- Any functions named "fn" will have a T_FN token for the function name, but have no scope information
10881088
- Thanks to [Michał Bundyra][@michalbundyra] for the help with this change
10891089
- PHP 7.4 numeric separators are now tokenized in the same way when using older PHP versions
10901090
- Previously, a number like 1_000 would tokenize as T_LNUMBER (1), T_STRING (_000)
@@ -1120,24 +1120,34 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
11201120
- Thanks to [Michał Bundyra][@michalbundyra] for the patch
11211121

11221122
### Fixed
1123-
- Fixed bug #2586 : Generic.WhiteSpace.ScopeIndent false positives when indenting open tags at a non tab-stop
1124-
- Fixed bug #2638 : Squiz.CSS.DuplicateClassDefinitionSniff sees comments as part of the class name
1123+
- Fixed bug [#2586] : Generic.WhiteSpace.ScopeIndent false positives when indenting open tags at a non tab-stop
1124+
- Fixed bug [#2638] : Squiz.CSS.DuplicateClassDefinitionSniff sees comments as part of the class name
11251125
- Thanks to [Raphael Horber][@rhorber] for the patch
1126-
- Fixed bug #2640 : Squiz.WhiteSpace.OperatorSpacing false positives for some negation operators
1126+
- Fixed bug [#2640] : Squiz.WhiteSpace.OperatorSpacing false positives for some negation operators
11271127
- Thanks to [Jakub Chábek][@grongor] and [Juliette Reinders Folmer][@jrfnl] for the patch
1128-
- Fixed bug #2674 : Squiz.Functions.FunctionDeclarationArgumentSpacing prints wrong argument name in error message
1129-
- Fixed bug #2676 : PSR12.Files.FileHeader locks up when file ends with multiple inline comments
1130-
- Fixed bug #2678 : PSR12.Classes.AnonClassDeclaration incorrectly enforcing that closing brace be on a line by itself
1131-
- Fixed bug #2685 : File::getMethodParameters() setting typeHintEndToken for vars with no type hint
1128+
- Fixed bug [#2674] : Squiz.Functions.FunctionDeclarationArgumentSpacing prints wrong argument name in error message
1129+
- Fixed bug [#2676] : PSR12.Files.FileHeader locks up when file ends with multiple inline comments
1130+
- Fixed bug [#2678] : PSR12.Classes.AnonClassDeclaration incorrectly enforcing that closing brace be on a line by itself
1131+
- Fixed bug [#2685] : File::getMethodParameters() setting typeHintEndToken for vars with no type hint
11321132
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1133-
- Fixed bug #2694 : AbstractArraySniff produces invalid indices when using ternary operator
1133+
- Fixed bug [#2694] : AbstractArraySniff produces invalid indices when using ternary operator
11341134
- Thanks to [Michał Bundyra][@michalbundyra] for the patch
1135-
- Fixed bug #2702 : Generic.WhiteSpace.ScopeIndent false positive when using ternary operator with short arrays
1135+
- Fixed bug [#2702] : Generic.WhiteSpace.ScopeIndent false positive when using ternary operator with short arrays
1136+
1137+
[#2586]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2586
1138+
[#2638]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2638
1139+
[#2640]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2640
1140+
[#2674]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2674
1141+
[#2676]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2676
1142+
[#2678]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2678
1143+
[#2685]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2685
1144+
[#2694]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2694
1145+
[#2702]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2702
11361146

11371147
## [3.5.2] - 2019-10-28
11381148
### Changed
11391149
- Generic.ControlStructures.DisallowYodaConditions now returns less false positives
1140-
- False positives were being returned for array comparisions, or when performing some function calls
1150+
- False positives were being returned for array comparisons, or when performing some function calls
11411151
- Squiz.WhiteSpace.SemicolonSpacing.Incorrect error message now escapes newlines and tabs
11421152
- Provides a clearer error message as whitespace is now visible
11431153
- Also allows for better output for report types such as CSV and XML
@@ -1146,13 +1156,20 @@ Additionally, thanks to [Alexander Turek][@derrabus] for consulting on the repo
11461156
- Thanks to [Craig Duncan][@duncan3dc] for the patch
11471157

11481158
### Fixed
1149-
- Fixed bug #2654 : Incorrect indentation for arguments of multiline function calls
1150-
- Fixed bug #2656 : Squiz.WhiteSpace.MemberVarSpacing removes comments before first member var during auto fixing
1151-
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1152-
- Fixed bug #2663 : Generic.NamingConventions.ConstructorName complains about old constructor in interfaces
1153-
- Fixed bug #2664 : PSR12.Files.OpenTag incorrectly identifies PHP file with only an opening tag
1154-
- Fixed bug #2665 : PSR12.Files.ImportStatement should not apply to traits
1155-
- Fixed bug #2673 : PSR12.Traits.UseDeclaration does not allow comments or blank lines between use statements
1159+
- Fixed bug [#2654] : Incorrect indentation for arguments of multiline function calls
1160+
- Fixed bug [#2656] : Squiz.WhiteSpace.MemberVarSpacing removes comments before first member var during auto fixing
1161+
- Thanks to [Juliette Reinders Folmer][@jrfnl] for the patch
1162+
- Fixed bug [#2663] : Generic.NamingConventions.ConstructorName complains about old constructor in interfaces
1163+
- Fixed bug [#2664] : PSR12.Files.OpenTag incorrectly identifies PHP file with only an opening tag
1164+
- Fixed bug [#2665] : PSR12.Files.ImportStatement should not apply to traits
1165+
- Fixed bug [#2673] : PSR12.Traits.UseDeclaration does not allow comments or blank lines between use statements
1166+
1167+
[#2654]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2654
1168+
[#2656]: https://github.com/squizlabs/PHP_CodeSniffer/pull/2656
1169+
[#2663]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2663
1170+
[#2664]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2664
1171+
[#2665]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2665
1172+
[#2673]: https://github.com/squizlabs/PHP_CodeSniffer/issues/2673
11561173

11571174
## [3.5.1] - 2019-10-17
11581175
### Changed

0 commit comments

Comments
 (0)