The Squiz coding standard now requires lowercase true/false/null for both PHP and JS files

Author: gsherwood

CodeSniffer/Standards/Squiz/Sniffs/NamingConventions/ConstantCaseSniff.php

@@ -15,6 +15,7 @@
  <rule ref="Generic.PHP.DeprecatedFunctions"/>
  <rule ref="Generic.PHP.DisallowShortOpenTag"/>
  <rule ref="Generic.PHP.LowerCaseKeyword"/>
+ <rule ref="Generic.PHP.LowerCaseConstant"/>
  <rule ref="Generic.Strings.UnnecessaryStringConcat"/>
  <rule ref="Generic.WhiteSpace.DisallowTabIndent"/>
  <rule ref="Generic.WhiteSpace.ScopeIndent"/>

CodeSniffer/Standards/Squiz/Tests/NamingConventions/ConstantCaseUnitTest.inc

@@ -40,6 +40,8 @@ http://pear.php.net/dtd/package-2.0.xsd">
     -- Useful for running the phpcs and phpcbf commands without any arguments at the top of a repository
   - Default file paths can now be specified in a ruleset.xml file using the "file" tag
     -- File paths are only processed if no files were specified on the command line
+  - Squiz coding standard now requires lowercase PHP constants (true, false and null)
+    -- Removed Squiz.NamingConventions.ConstantCase sniff as the rule is now consistent across PHP and JS files
   - Interactive mode no longer breaks if you also specify a report type on the command line
   - PEAR InlineCommentSniff now fixes the Perl-style comments that it finds (request #375)
   - PSR2 standard no longer fixes the placement of docblock open tags as comments are excluded from this standard
@@ -1542,9 +1544,6 @@ http://pear.php.net/dtd/package-2.0.xsd">
         </file>
        </dir>
        <dir name="NamingConventions">
-        <file baseinstalldir="PHP" name="ConstantCaseSniff.php" role="php">
-         <tasks:replace from="@package_version@" to="version" type="package-info" />
-        </file>
         <file baseinstalldir="PHP" name="ValidFunctionNameSniff.php" role="php">
          <tasks:replace from="@package_version@" to="version" type="package-info" />
         </file>
@@ -1958,11 +1957,6 @@ http://pear.php.net/dtd/package-2.0.xsd">
         </file>
        </dir>
        <dir name="NamingConventions">
-        <file baseinstalldir="PHP" name="ConstantCaseUnitTest.inc" role="test" />
-        <file baseinstalldir="PHP" name="ConstantCaseUnitTest.js" role="test" />
-        <file baseinstalldir="PHP" name="ConstantCaseUnitTest.php" role="test">
-         <tasks:replace from="@package_version@" to="version" type="package-info" />
-        </file>
         <file baseinstalldir="PHP" name="ValidFunctionNameUnitTest.inc" role="test" />
         <file baseinstalldir="PHP" name="ValidFunctionNameUnitTest.php" role="test">
          <tasks:replace from="@package_version@" to="version" type="package-info" />