Skip to content

Commit 78541c4

Browse files
committed
Make it easier to read test cases by renaming a variable
Also improves a code comment in the test file
1 parent c0b125e commit 78541c4

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

src/Standards/Generic/Tests/CodeAnalysis/JumbledIncrementerUnitTest.1.inc

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@ for (; $i < 10; $i++) {
3737
}
3838
}
3939

40-
for (; $i < 10; $i++) {
41-
for ($j = 0;; $i++) {
40+
for (; $same < 10; $same++) {
41+
for ($j = 0;; $same++) {
4242
if ($j > 5) {
4343
break;
4444
}
45-
for (;; $i++) {
45+
for (;; $same++) {
4646
if ($k > 5) {
4747
break;
4848
}
@@ -55,19 +55,19 @@ for ($i = 0; $i < 20; $i++) :
5555
endfor;
5656
endfor;
5757

58-
for ($i = 0; $i < 20; $i++) :
59-
for ($j = 0; $j < 5; $i += 2) :
58+
for ($same = 0; $same < 20; $same++) :
59+
for ($j = 0; $j < 5; $same += 2) :
6060
endfor;
6161
endfor;
6262

63-
// Sniff bails early when there is no incrementor in the third expression of the outer for loop.
64-
for ($i = 0; $i < 10;) {
65-
++$i;
66-
for ($j = 0; $j < 5; $i++) {}
63+
// Sniff bails early when the third expression of the outer for loop is empty.
64+
for ($same = 0; $same < 10;) {
65+
++$same;
66+
for ($j = 0; $j < 5; $same++) {}
6767
}
6868

69-
for ($i = 1, $j = 0; $i <= 10; $i++, $j++) {
70-
for ($j = 0, $k = 0; $k < 5; $j++, $k++) {}
69+
for ($i = 1, $same = 0; $i <= 10; $i++, $same++) {
70+
for ($same = 0, $k = 0; $k < 5; $same++, $k++) {}
7171
}
7272

7373
for ($i = 20; $i > 0; $i--) {
@@ -76,8 +76,8 @@ for ($i = 20; $i > 0; $i--) {
7676
}
7777
}
7878

79-
for ($i = 20; $i > 0; $i--) {
80-
for ($j = 5; $j > 0; $i -= 2) {
81-
for ($k = 3; $k > 0; $i--) {}
79+
for ($same = 20; $same > 0; $same--) {
80+
for ($j = 5; $j > 0; $same -= 2) {
81+
for ($k = 3; $k > 0; $same--) {}
8282
}
8383
}

0 commit comments

Comments
 (0)