Skip to content

Commit b7dcdf8

Browse files
authored
Merge pull request #666 from PHPCSStandards/feature/ghactions-dont-fail-on-8.4
GH Actions: update for the release of PHP 8.4
2 parents c2b6235 + fda697f commit b7dcdf8

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

.github/workflows/build-phar.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,11 @@ jobs:
2525
strategy:
2626
matrix:
2727
# Deliberately missing PHP 8.0 as that PHAR is build and used in the test workflow.
28-
php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.1', '8.2', '8.3', '8.4']
28+
php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.1', '8.2', '8.3', '8.4', '8.5']
2929

3030
name: "Build Phar on PHP: ${{ matrix.php }}"
3131

32-
continue-on-error: ${{ matrix.php == '8.4' }}
32+
continue-on-error: ${{ matrix.php == '8.5' }}
3333

3434
steps:
3535
- name: Checkout code

.github/workflows/test.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,15 +88,15 @@ jobs:
8888
# - custom_ini: Whether to run with specific custom ini settings to hit very specific
8989
# code conditions.
9090
matrix:
91-
php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
91+
php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
9292
custom_ini: [false]
9393

9494
include:
95-
# Skip test runs on builds which are also run for in the coverage job.
96-
# Note: the tests on PHP 7.2 will still be run as the coverage build is uses custom_ini for that version.
95+
# Skip test runs on builds which are also run in the coverage job.
96+
# Note: the tests on PHP 7.2 will still be run as the coverage build uses custom_ini settings for that version.
9797
- php: '5.4'
9898
skip_tests: true
99-
- php: '8.3'
99+
- php: '8.4'
100100
skip_tests: true
101101

102102
# Extra builds running only the unit tests with different PHP ini settings.
@@ -107,7 +107,7 @@ jobs:
107107

108108
name: "PHP: ${{ matrix.php }} ${{ matrix.custom_ini && ' with custom ini settings' || '' }}"
109109

110-
continue-on-error: ${{ matrix.php == '8.4' }}
110+
continue-on-error: ${{ matrix.php == '8.5' }}
111111

112112
steps:
113113
- name: Checkout code
@@ -154,7 +154,7 @@ jobs:
154154
- name: Install Composer dependencies
155155
uses: "ramsey/composer-install@v3"
156156
with:
157-
composer-options: ${{ matrix.php == '8.4' && '--ignore-platform-req=php' || '' }}
157+
composer-options: ${{ matrix.php == '8.5' && '--ignore-platform-req=php' || '' }}
158158
custom-cache-suffix: $(date -u "+%Y-%m")
159159

160160
# Note: The code style check is run multiple times against every PHP version
@@ -200,7 +200,7 @@ jobs:
200200
custom_ini: false
201201
- php: '7.2'
202202
custom_ini: true
203-
- php: '8.3'
203+
- php: '8.4'
204204
custom_ini: false
205205

206206
name: "Coverage: ${{ matrix.php }} ${{ matrix.custom_ini && ' with custom ini settings' || '' }}"

0 commit comments

Comments
 (0)