Skip to content

Minor bug - fatal error in psr16 adapter if an exception is thrown #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2019

Conversation

MaximilianKresse
Copy link
Contributor

Proposed changes

There is an minor bug in the psr16 adapter, the couchdb driver and the mongodb driver.

You throw multiple exceptions with code "NULL". But this will trigger a fatal error in strict mode: https://3v4l.org/fimJH

Types of changes

What types of changes does your code introduce to Phpfastcache?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing code/behavior)
  • Deprecated third party dependency update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation/Typo/Resource update that does not involve any code modification

Agreement

I have read the CONTRIBUTING and CODING GUIDELINE docs

@Geolim4
Copy link
Member

Geolim4 commented Apr 9, 2019

oO how that thing could pass the tests ?
Thanks you for the PR !!

@Geolim4 Geolim4 merged commit de6ebf7 into PHPSocialNetwork:master Apr 9, 2019
@Geolim4 Geolim4 self-assigned this Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants