Fatal type error with ssdb-server >1.9.7 #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On this version the server return 0 or 1
|
Hello, Thanks you for your contribution ! Cheers, |
In version 1.9.7 of ssdb, it replies with an integer instead of a Bolean generating the following error: "Return value of Phpfastcache Drivers SSdb Driver :: driverDelete () must be of the type boolean, integer returned" and "Return value of Phpfastcache Drivers SSdb Driver :: driverClear () must be of the type boolean, integer returned"
|
I made the same fix for the methods: |
Don't worry, I'll squash them :) |
Geolim4
approved these changes
Aug 2, 2019
|
I'll make a new release by the end of week, meanwhile you can use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this version the server return 0 or 1
Proposed changes
In version 1.9.7 of ssdb, it replies with an integer instead of a Bolean generating the following error:
"Return value of Phpfastcache Drivers SSdb Driver :: driverWrite () must be of the type boolean, integer returned"
Types of changes
What types of changes does your code introduce to Phpfastcache?
Put an
xin the boxes that applyAgreement
I have read the CONTRIBUTING and CODING GUIDELINE docs
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...