Skip to content

Commit 4abcad6

Browse files
committed
i18n [nfc]: Mention issue for translating styled strings
Signed-off-by: Zixuan James Li <[email protected]>
1 parent 5e9933a commit 4abcad6

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

lib/model/compose.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ String quoteAndReplyPlaceholder(PerAccountStore store, {
191191
SendableNarrow.ofMessage(message, selfUserId: store.selfUserId),
192192
nearMessageId: message.id);
193193
// See note in [quoteAndReply] about asking `mention` to omit the |<id> part.
194-
return '${userMention(sender!, silent: true)} ${inlineLink('said', url)}: ' // TODO(i18n) ?
194+
return '${userMention(sender!, silent: true)} ${inlineLink('said', url)}: ' // TODO(#1285)
195195
'*(loading message ${message.id})*\n'; // TODO(i18n) ?
196196
}
197197

@@ -215,6 +215,6 @@ String quoteAndReply(PerAccountStore store, {
215215
// Could ask `mention` to omit the |<id> part unless the mention is ambiguous…
216216
// but that would mean a linear scan through all users, and the extra noise
217217
// won't much matter with the already probably-long message link in there too.
218-
return '${userMention(sender!, silent: true)} ${inlineLink('said', url)}:\n' // TODO(i18n) ?
218+
return '${userMention(sender!, silent: true)} ${inlineLink('said', url)}:\n' // TODO(#1285)
219219
'${wrapWithBacktickFence(content: rawContent, infoString: 'quote')}';
220220
}

lib/widgets/content.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1570,6 +1570,7 @@ InlineSpan _errorUnimplemented(UnimplementedNode node, {required BuildContext co
15701570
// because release mode isn't yet about general users but developer demos,
15711571
// and we want to keep the demos honest.
15721572
// TODO(#194) think through UX for general release
1573+
// TODO(#1285) translate this
15731574
final htmlNode = node.htmlNode;
15741575
if (htmlNode is dom.Element) {
15751576
return TextSpan(children: [

0 commit comments

Comments
 (0)