Skip to content

Commit 502c989

Browse files
committed
bug fix: explicitly use MPI.Datatype in function argument
1 parent b88c234 commit 502c989

File tree

1 file changed

+29
-30
lines changed

1 file changed

+29
-30
lines changed

src/pnetcdf/_Variable.pyx

Lines changed: 29 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ cimport numpy
2828
numpy.import_array()
2929

3030

31-
ctypedef MPI.Datatype Datatype
3231

3332

3433
cdef class Variable:
@@ -699,7 +698,7 @@ cdef class Variable:
699698
self._put(dataput,a,b,c)
700699

701700

702-
def _put_var1(self, value, tuple index, bufcount, Datatype buftype, collective = True):
701+
def _put_var1(self, value, tuple index, bufcount, MPI.Datatype buftype, collective = True):
703702
cdef int ierr, ndims
704703
cdef size_t *indexp
705704
cdef MPI_Offset buffcount
@@ -735,7 +734,7 @@ cdef class Variable:
735734
_check_err(ierr)
736735
free(indexp)
737736

738-
def _put_var(self, ndarray data, bufcount, Datatype buftype, collective = True):
737+
def _put_var(self, ndarray data, bufcount, MPI.Datatype buftype, collective = True):
739738
cdef int ierr, ndims
740739
cdef MPI_Offset buffcount
741740
cdef MPI_Datatype bufftype
@@ -765,7 +764,7 @@ cdef class Variable:
765764
PyArray_DATA(data), buffcount, bufftype)
766765
_check_err(ierr)
767766

768-
def _put_vara(self, start, count, ndarray data, bufcount, Datatype buftype, collective = True):
767+
def _put_vara(self, start, count, ndarray data, bufcount, MPI.Datatype buftype, collective = True):
769768
cdef int ierr, ndims
770769
cdef MPI_Offset buffcount
771770
cdef MPI_Datatype bufftype
@@ -802,7 +801,7 @@ cdef class Variable:
802801
PyArray_DATA(data), buffcount, bufftype)
803802
_check_err(ierr)
804803

805-
def _put_varn(self, ndarray data, num, starts, counts=None, bufcount=None, buftype=None, collective = True):
804+
def _put_varn(self, ndarray data, num, starts, counts=None, bufcount=None, MPI.Datatype buftype=None, collective = True):
806805
cdef int ierr, ndims
807806
cdef MPI_Offset buffcount
808807
cdef MPI_Datatype bufftype
@@ -862,7 +861,7 @@ cdef class Variable:
862861
bufftype)
863862
_check_err(ierr)
864863

865-
def put_varn_all(self, data, num, starts, counts=None, bufcount=None, buftype=None):
864+
def put_varn_all(self, data, num, starts, counts=None, bufcount=None, MPI.Datatype buftype=None):
866865
"""
867866
put_varn_all(self, data, num, starts, counts=None, bufcount=None, buftype=None)
868867
@@ -967,7 +966,7 @@ cdef class Variable:
967966
self._put_varn(data, num, starts, counts, bufcount = bufcount,
968967
buftype = buftype, collective = True)
969968

970-
def put_varn(self, data, num, starts, counts=None, bufcount=None, buftype=None):
969+
def put_varn(self, data, num, starts, counts=None, bufcount=None, MPI.Datatype buftype=None):
971970
"""
972971
put_varn(self, data, num, starts, counts=None, bufcount=None, buftype=None)
973972
@@ -979,7 +978,7 @@ cdef class Variable:
979978
self._put_varn(data, num, starts, counts, bufcount = bufcount,
980979
buftype = buftype, collective = False)
981980

982-
def iput_varn(self, data, num, starts, counts=None, bufcount=None, buftype=None):
981+
def iput_varn(self, data, num, starts, counts=None, bufcount=None, MPI.Datatype buftype=None):
983982
"""
984983
iput_varn(self, data, num, starts, counts=None, bufcount=None, buftype=None)
985984
@@ -1008,7 +1007,7 @@ cdef class Variable:
10081007
return self._iput_varn(data, num, starts, counts, bufcount, buftype,
10091008
buffered=False)
10101009

1011-
def bput_varn(self, data, num, starts, counts=None, bufcount=None, buftype=None):
1010+
def bput_varn(self, data, num, starts, counts=None, bufcount=None, MPI.Datatype buftype=None):
10121011
"""
10131012
bput_varn(self, data, num, starts, counts=None, bufcount=None, buftype=None)
10141013
@@ -1035,7 +1034,7 @@ cdef class Variable:
10351034
"""
10361035
return self._iput_varn(data, num, starts, counts, bufcount, buftype, buffered=True)
10371036

1038-
def _put_vars(self, start, count, stride, ndarray data, bufcount, Datatype buftype, collective = True):
1037+
def _put_vars(self, start, count, stride, ndarray data, bufcount, MPI.Datatype buftype, collective = True):
10391038
cdef int ierr, ndims
10401039
cdef MPI_Offset buffcount
10411040
cdef MPI_Datatype bufftype
@@ -1078,7 +1077,7 @@ cdef class Variable:
10781077
_check_err(ierr)
10791078

10801079

1081-
def _put_varm(self, ndarray data, start, count, stride, imap, bufcount, Datatype buftype, collective = True):
1080+
def _put_varm(self, ndarray data, start, count, stride, imap, bufcount, MPI.Datatype buftype, collective = True):
10821081
cdef int ierr, ndims
10831082
cdef MPI_Offset buffcount
10841083
cdef MPI_Datatype bufftype
@@ -1131,7 +1130,7 @@ cdef class Variable:
11311130

11321131

11331132

1134-
def put_var_all(self, data, start=None, count=None, stride=None, imap=None, bufcount=None, buftype=None):
1133+
def put_var_all(self, data, start=None, count=None, stride=None, imap=None, bufcount=None, MPI.Datatype buftype=None):
11351134
"""
11361135
put_var_all(self, data, start=None, count=None, stride=None, imap=None, bufcount=None, buftype=None)
11371136
@@ -1423,7 +1422,7 @@ cdef class Variable:
14231422
free(countp)
14241423
free(stridep)
14251424

1426-
def _get_var1(self, ndarray buff, index, bufcount, Datatype buftype, collective = True):
1425+
def _get_var1(self, ndarray buff, index, bufcount, MPI.Datatype buftype, collective = True):
14271426
cdef int ierr, ndims
14281427
cdef size_t *indexp
14291428
cdef MPI_Offset buffcount
@@ -1453,7 +1452,7 @@ cdef class Variable:
14531452
free(indexp)
14541453

14551454

1456-
def _get_var(self, ndarray buff, bufcount, Datatype buftype, collective = True):
1455+
def _get_var(self, ndarray buff, bufcount, MPI.Datatype buftype, collective = True):
14571456
cdef int ierr, ndims
14581457
cdef MPI_Offset buffcount
14591458
cdef MPI_Datatype bufftype
@@ -1479,7 +1478,7 @@ cdef class Variable:
14791478
_check_err(ierr)
14801479

14811480

1482-
def _get_vara(self, ndarray buff, start, count, bufcount, Datatype buftype, collective = True):
1481+
def _get_vara(self, ndarray buff, start, count, bufcount, MPI.Datatype buftype, collective = True):
14831482
cdef int ierr, ndims
14841483
cdef MPI_Offset buffcount
14851484
cdef MPI_Datatype bufftype
@@ -1513,7 +1512,7 @@ cdef class Variable:
15131512

15141513
_check_err(ierr)
15151514

1516-
def _get_varn(self, ndarray data, num, starts, counts, bufcount, Datatype buftype, collective = True):
1515+
def _get_varn(self, ndarray data, num, starts, counts, bufcount, MPI.Datatype buftype, collective = True):
15171516
cdef int ierr, ndims
15181517
cdef MPI_Offset buffcount
15191518
cdef MPI_Datatype bufftype
@@ -1569,7 +1568,7 @@ cdef class Variable:
15691568

15701569
_check_err(ierr)
15711570

1572-
def _get_vars(self, ndarray buff, start, count, stride, bufcount, Datatype buftype, collective = True):
1571+
def _get_vars(self, ndarray buff, start, count, stride, bufcount, MPI.Datatype buftype, collective = True):
15731572
cdef int ierr, ndims
15741573
cdef MPI_Offset buffcount
15751574
cdef MPI_Datatype bufftype
@@ -1606,7 +1605,7 @@ cdef class Variable:
16061605

16071606
_check_err(ierr)
16081607

1609-
def _get_varm(self, ndarray buff, start, count, stride, imap, bufcount, Datatype buftype, collective = True):
1608+
def _get_varm(self, ndarray buff, start, count, stride, imap, bufcount, MPI.Datatype buftype, collective = True):
16101609
cdef int ierr, ndims
16111610
cdef MPI_Offset buffcount
16121611
cdef MPI_Datatype bufftype
@@ -2058,7 +2057,7 @@ cdef class Variable:
20582057
else:
20592058
return data
20602059

2061-
def _iput_var(self, ndarray data, bufcount, Datatype buftype, buffered = False):
2060+
def _iput_var(self, ndarray data, bufcount, MPI.Datatype buftype, buffered = False):
20622061
cdef int ierr, ndims
20632062
cdef MPI_Offset buffcount
20642063
cdef MPI_Datatype bufftype
@@ -2090,7 +2089,7 @@ cdef class Variable:
20902089
_check_err(ierr)
20912090
return request
20922091

2093-
def _iput_var1(self, value, index, bufcount, Datatype buftype, buffered=False):
2092+
def _iput_var1(self, value, index, bufcount, MPI.Datatype buftype, buffered=False):
20942093
cdef int ierr, ndims
20952094
cdef size_t *indexp
20962095
cdef MPI_Offset buffcount
@@ -2127,7 +2126,7 @@ cdef class Variable:
21272126
_check_err(ierr)
21282127
return request
21292128

2130-
def _iput_vara(self, start, count, ndarray data, bufcount, Datatype buftype, buffered=False):
2129+
def _iput_vara(self, start, count, ndarray data, bufcount, MPI.Datatype buftype, buffered=False):
21312130
cdef int ierr, ndims
21322131
cdef MPI_Offset buffcount
21332132
cdef MPI_Datatype bufftype
@@ -2166,7 +2165,7 @@ cdef class Variable:
21662165
_check_err(ierr)
21672166
return request
21682167

2169-
def _iput_vars(self, start, count, stride, ndarray data, bufcount, Datatype buftype, buffered=False):
2168+
def _iput_vars(self, start, count, stride, ndarray data, bufcount, MPI.Datatype buftype, buffered=False):
21702169
cdef int ierr, ndims
21712170
cdef MPI_Offset buffcount
21722171
cdef MPI_Datatype bufftype
@@ -2206,7 +2205,7 @@ cdef class Variable:
22062205
_check_err(ierr)
22072206
return request
22082207

2209-
def _iput_varn(self, ndarray data, num, starts, counts, bufcount, Datatype buftype, buffered=False):
2208+
def _iput_varn(self, ndarray data, num, starts, counts, bufcount, MPI.Datatype buftype, buffered=False):
22102209
cdef int ierr, ndims
22112210
cdef MPI_Offset buffcount
22122211
cdef MPI_Datatype bufftype
@@ -2270,7 +2269,7 @@ cdef class Variable:
22702269
_check_err(ierr)
22712270
return request
22722271

2273-
def _iput_varm(self, ndarray data, start, count, stride, imap, bufcount, Datatype buftype, buffered=False):
2272+
def _iput_varm(self, ndarray data, start, count, stride, imap, bufcount, MPI.Datatype buftype, buffered=False):
22742273
cdef int ierr, ndims
22752274
cdef MPI_Offset buffcount
22762275
cdef MPI_Datatype bufftype
@@ -2405,7 +2404,7 @@ cdef class Variable:
24052404
else:
24062405
raise ValueError("Invalid input arguments for iput_var")
24072406

2408-
def _iget_var(self, ndarray data, bufcount, Datatype buftype):
2407+
def _iget_var(self, ndarray data, bufcount, MPI.Datatype buftype):
24092408
cdef int ierr, ndims
24102409
cdef MPI_Offset buffcount
24112410
cdef MPI_Datatype bufftype
@@ -2425,7 +2424,7 @@ cdef class Variable:
24252424
return request
24262425

24272426

2428-
def _iget_var1(self, ndarray buff, index, bufcount, Datatype buftype):
2427+
def _iget_var1(self, ndarray buff, index, bufcount, MPI.Datatype buftype):
24292428
cdef int ierr, ndims
24302429
cdef size_t *indexp
24312430
cdef MPI_Offset buffcount
@@ -2452,7 +2451,7 @@ cdef class Variable:
24522451
return request
24532452

24542453

2455-
def _iget_vara(self, ndarray data, start, count, bufcount, Datatype buftype):
2454+
def _iget_vara(self, ndarray data, start, count, bufcount, MPI.Datatype buftype):
24562455
cdef int ierr, ndims
24572456
cdef MPI_Offset buffcount
24582457
cdef MPI_Datatype bufftype
@@ -2481,7 +2480,7 @@ cdef class Variable:
24812480
_check_err(ierr)
24822481
return request
24832482

2484-
def _iget_vars(self, ndarray buff, start, count, stride, bufcount, Datatype buftype):
2483+
def _iget_vars(self, ndarray buff, start, count, stride, bufcount, MPI.Datatype buftype):
24852484
cdef int ierr, ndims
24862485
cdef MPI_Offset buffcount
24872486
cdef MPI_Datatype bufftype
@@ -2513,7 +2512,7 @@ cdef class Variable:
25132512
_check_err(ierr)
25142513
return request
25152514

2516-
def iget_varn(self, ndarray data, num, starts, counts=None, bufcount=None, Datatype buftype=None):
2515+
def iget_varn(self, ndarray data, num, starts, counts=None, bufcount=None, MPI.Datatype buftype=None):
25172516
"""
25182517
iget_varn(self, data, num, starts, counts=None, bufcount=None, buftype=None)
25192518
@@ -2585,7 +2584,7 @@ cdef class Variable:
25852584
_check_err(ierr)
25862585
return request
25872586

2588-
def _iget_varm(self, ndarray buff, start, count, stride, imap, bufcount, Datatype buftype):
2587+
def _iget_varm(self, ndarray buff, start, count, stride, imap, bufcount, MPI.Datatype buftype):
25892588
cdef int ierr, ndims
25902589
cdef MPI_Offset buffcount
25912590
cdef MPI_Datatype bufftype

0 commit comments

Comments
 (0)