Skip to content

Host logging enabled by default or not? #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pkittenis opened this issue Mar 31, 2015 · 1 comment
Closed

Host logging enabled by default or not? #29

pkittenis opened this issue Mar 31, 2015 · 1 comment
Milestone

Comments

@pkittenis
Copy link
Member

Related to #27 - host logging via the logger named pssh.host_logger is enabled by default.

Since ParallelSSH is a library, it probably should not have logging enabled by default and instead leave that up to the application using the library.

Would agree with this in principle, although in all real-world use cases of ParallelSSH I have seen and done myself, host logging is indeed wanted.

In all my particular use cases ParallelSSH is used by another application in a job on a build server somewhere.

Host logging is useful and wanted though the build server does not show output unless you click on Console Output or similar to see output from the job.

At that point, if host logging were not enabled by default, the output would simply not be available.

@nchammas is proposing turning host logging off by default, something that, as above, I am not opposed to on principle.

We can have a single function to call to turn host logging back on.

Question is, what are other users of ParallelSSH doing with host logging?

Happy with it enabled by default or are you having to remove the handler per docs?

@pkittenis
Copy link
Member Author

Going to remove the default handler in next point release.

Agree that library should not have any handlers attached by default - it is up to application using library to enable them or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant