Skip to content

Commit 0ed058e

Browse files
committed
review: test different /DEBUG values.
Signed-off-by: Piotr Sikora <[email protected]>
1 parent 5bbdbb6 commit 0ed058e

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

.github/workflows/cpp.yml

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -66,15 +66,18 @@ jobs:
6666
fail-fast: false
6767
matrix:
6868
include:
69-
- name: 'V8 on Windows #1'
69+
- name: 'V8 on Windows #1 (full)'
7070
runtime: 'v8'
7171
os: windows-2019
72-
- name: 'V8 on Windows #2'
72+
flags: '--linkopt=/DEBUG:FULL'
73+
- name: 'V8 on Windows #2 (fastlink)'
7374
runtime: 'v8'
7475
os: windows-2019
75-
- name: 'V8 on Windows #3'
76+
flags: '--linkopt=/DEBUG:FASTLINK'
77+
- name: 'V8 on Windows #3 (none)'
7678
runtime: 'v8'
7779
os: windows-2019
80+
flags: '--linkopt=/DEBUG:NONE'
7881

7982
steps:
8083
- uses: actions/checkout@v2
@@ -99,20 +102,20 @@ jobs:
99102
- name: Generate inspector files
100103
if: matrix.runtime == 'v8'
101104
run: |
102-
bazel build --verbose_failures --test_output=errors --define runtime=${{ matrix.runtime }} @v8//:generated_inspector_files
105+
bazel build ${{ matrix.flags }} --verbose_failures --test_output=errors --define runtime=${{ matrix.runtime }} @v8//:generated_inspector_files
103106
104107
- name: Generate torque files
105108
if: matrix.runtime == 'v8'
106109
run: |
107-
bazel build --verbose_failures --test_output=errors --define runtime=${{ matrix.runtime }} @v8//:noicu/generated_torque_files
110+
bazel build ${{ matrix.flags }} --verbose_failures --test_output=errors --define runtime=${{ matrix.runtime }} @v8//:noicu/generated_torque_files
108111
109112
- name: Test
110113
run: |
111-
bazel test --verbose_failures --test_output=errors --define runtime=${{ matrix.runtime }} //test/...
114+
bazel test ${{ matrix.flags }} --verbose_failures --test_output=errors --define runtime=${{ matrix.runtime }} //test/... || cat bazel-out/x64_windows-fastbuild/bin/external/v8/v8_libshared_noicu.lo.lib-2.params
112115
113116
- name: Test (signed Wasm module)
114117
run: |
115-
bazel test --verbose_failures --test_output=errors --define runtime=${{ matrix.runtime }} --per_file_copt=src/signature_util.cc,test/signature_util_test.cc@-DPROXY_WASM_VERIFY_WITH_ED25519_PUBKEY=\"$(xxd -p -c 256 test/test_data/signature_key1.pub | cut -b9-)\" //test:signature_util_test
118+
bazel test ${{ matrix.flags }} --verbose_failures --test_output=errors --define runtime=${{ matrix.runtime }} --per_file_copt=src/signature_util.cc,test/signature_util_test.cc@-DPROXY_WASM_VERIFY_WITH_ED25519_PUBKEY=\"$(xxd -p -c 256 test/test_data/signature_key1.pub | cut -b9-)\" //test:signature_util_test
116119
117120
- name: Cleanup Bazel cache
118121
if: matrix.runtime != 'wasmtime'

0 commit comments

Comments
 (0)