review: update V8 to v9.9.67 and regenerate patches.

Signed-off-by: Piotr Sikora <[email protected]>

Author: PiotrSikora

bazel/external/v8.patch

@@ -1,12 +1,9 @@
 1. Manage dependencies in Bazel. (https://crrev.com/c/3344621)
 2. Generate inspector files using @rules_python. (https://crrev.com/c/3343881)
-3. Fix build with older versions of GCC. (https://crrev.com/c/3368869)
-4. Fix build on arm64. (https://crrev.com/c/3368870)
-5. Fix build on Windows. (https://crrev.com/c/3368871)
-6. Add support for building on s390x. (https://crrev.com/c/3346395)
+3. Add support for building on s390x. (https://crrev.com/c/3346395)
 
 diff --git a/BUILD.bazel b/BUILD.bazel
-index 5d607a5048..d2f3030326 100644
+index 5d607a5048..8a2041a75d 100644
 --- a/BUILD.bazel
 +++ b/BUILD.bazel
 @@ -3,6 +3,8 @@
@@ -208,7 +205,7 @@ index 5d607a5048..d2f3030326 100644
      deps = [
          ":v8_libbase",
 -        "@zlib",
-+        "@com_googlesource_chromium_trace_event_common//:trace_event_common",
++        "@com_googlesource_chromium_base_trace_event_common//:trace_event_common",
 +        "@com_googlesource_chromium_zlib//:zlib",
      ],
  )
@@ -223,59 +220,31 @@ index 5d607a5048..d2f3030326 100644
  )
 
 diff --git a/WORKSPACE b/WORKSPACE
-index 289902f68d..c9331b34cf 100644
+index 289902f68d..9cc1f0be95 100644
 --- a/WORKSPACE
 +++ b/WORKSPACE
-@@ -4,7 +4,9 @@
- 
- workspace(name = "v8")
- 
-+load("@bazel_tools//tools/build_defs/repo:git.bzl", "new_git_repository")
- load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
-+
- http_archive(
-     name = "bazel_skylib",
-     urls = [
-@@ -16,14 +18,38 @@ http_archive(
+@@ -16,14 +16,20 @@ http_archive(
  load("@bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")
  bazel_skylib_workspace()
 
 -new_local_repository(
 -    name = "zlib",
 -    path = "third_party/zlib",
 -    build_file = "bazel/BUILD.zlib",
-+new_git_repository(
-+    name = "com_googlesource_chromium_icu",
-+    build_file = "//:bazel/BUILD.icu",
-+    commit = "fbc6faf1c2c429cd27fabe615a89f0b217aa4213",
-+    remote = "https://chromium.googlesource.com/chromium/deps/icu.git",
-+)
-+
-+new_git_repository(
-+    name = "com_googlesource_chromium_trace_event_common",
-+    build_file = "//:bazel/BUILD.trace_event_common",
-+    commit = "7f36dbc19d31e2aad895c60261ca8f726442bfbb",
-+    remote = "https://chromium.googlesource.com/chromium/src/base/trace_event/common.git",
-+)
++load("@v8//:bazel/repositories.bzl", "v8_repositories")
++v8_repositories()
 +
-+new_git_repository(
-+    name = "com_googlesource_chromium_zlib",
-+    build_file = "//:bazel/BUILD.zlib",
-+    commit = "efd9399ae01364926be2a38946127fdf463480db",
-+    remote = "https://chromium.googlesource.com/chromium/src/third_party/zlib.git",
++http_archive(
++    name = "rules_python",
++    sha256 = "a30abdfc7126d497a7698c29c46ea9901c6392d6ed315171a6df5ce433aa4502",
++    strip_prefix = "rules_python-0.6.0",
++    url = "https://github.com/bazelbuild/rules_python/archive/0.6.0.tar.gz",
  )
 
 -new_local_repository(
 -    name = "icu",
 -    path = "third_party/icu",
 -    build_file = "bazel/BUILD.icu",
-+http_archive(
-+    name = "rules_python",
-+    sha256 = "a30abdfc7126d497a7698c29c46ea9901c6392d6ed315171a6df5ce433aa4502",
-+    strip_prefix = "rules_python-0.6.0",
-+    url = "https://github.com/bazelbuild/rules_python/archive/0.6.0.tar.gz",
-+)
-+
 +load("@rules_python//python:pip.bzl", "pip_install")
 +
 +pip_install(
@@ -353,35 +322,22 @@ index 2d5d241ebf..72aae9e270 100644
      if cpu_type in allowed_values:
          return V8CpuTypeInfo(value = cpu_type)
 diff --git a/bazel/defs.bzl b/bazel/defs.bzl
-index 14fff6f049..35f0442f6c 100644
+index 088d989b99..7b163a333f 100644
 --- a/bazel/defs.bzl
 +++ b/bazel/defs.bzl
-@@ -120,13 +120,17 @@ def _default_args():
+@@ -146,6 +146,11 @@ def _default_args():
+                 "-O1",
              ],
-             "@v8//bazel/config:is_gcc": [
-                 "-Wno-extra",
-+                "-Wno-array-bounds",
-+                "-Wno-class-memaccess",
-                 "-Wno-comments",
-                 "-Wno-deprecated-declarations",
-                 "-Wno-implicit-fallthrough",
-+                "-Wno-int-in-bool-context",
-                 "-Wno-maybe-uninitialized",
-                 "-Wno-mismatched-new-delete",
-                 "-Wno-redundant-move",
-                 "-Wno-return-type",
-+                "-Wno-stringop-overflow",
-                 # Use GNU dialect, because GCC doesn't allow using
-                 # ##__VA_ARGS__ when in standards-conforming mode.
-                 "-std=gnu++17",
-@@ -367,11 +371,14 @@ def _v8_target_cpu_transition_impl(settings, attr):
-         "x86_64": "x64",
-         "darwin": "x64",
-         "darwin_x86_64": "x64",
-+        "x64_windows": "x64",
-         "x86": "ia32",
-         "ppc": "ppc64",
-+        "aarch64": "arm64",
+             "//conditions:default": [],
++        }) + select({
++            "@v8//bazel/config:is_s390x": [
++                "-fno-integrated-as",
++            ],
++            "//conditions:default": [],
+         }),
+         includes = ["include"],
+         linkopts = select({
+@@ -378,6 +383,7 @@ def _v8_target_cpu_transition_impl(settings, attr):
          "arm64-v8a": "arm64",
          "arm": "arm64",
          "armeabi-v7a": "arm32",
@@ -447,6 +403,43 @@ index 9547041c33..0000000000
 -# Copy generated files to bazel output folder
 -cp out/inspector/gen/include/inspector/* $BAZEL_OUT/include/inspector/
 -cp out/inspector/gen/src/inspector/protocol/* $BAZEL_OUT/src/inspector/protocol/
+diff --git a/bazel/repositories.bzl b/bazel/repositories.bzl
+new file mode 100644
+index 0000000000..5a9242a090
+--- /dev/null
++++ b/bazel/repositories.bzl
+@@ -0,0 +1,31 @@
++# Copyright 2021 the V8 project authors. All rights reserved.
++# Use of this source code is governed by a BSD-style license that can be
++# found in the LICENSE file.
++
++load("@bazel_tools//tools/build_defs/repo:git.bzl", "new_git_repository")
++load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")
++
++def v8_repositories():
++    maybe(
++        new_git_repository,
++        name = "com_googlesource_chromium_base_trace_event_common",
++        build_file = "@v8//:bazel/BUILD.trace_event_common",
++        commit = "7f36dbc19d31e2aad895c60261ca8f726442bfbb",
++        remote = "https://chromium.googlesource.com/chromium/src/base/trace_event/common.git",
++    )
++
++    maybe(
++        new_git_repository,
++        name = "com_googlesource_chromium_icu",
++        build_file = "@v8//:bazel/BUILD.icu",
++        commit = "fbc6faf1c2c429cd27fabe615a89f0b217aa4213",
++        remote = "https://chromium.googlesource.com/chromium/deps/icu.git",
++    )
++
++    maybe(
++        new_git_repository,
++        name = "com_googlesource_chromium_zlib",
++        build_file = "@v8//:bazel/BUILD.zlib",
++        commit = "efd9399ae01364926be2a38946127fdf463480db",
++        remote = "https://chromium.googlesource.com/chromium/src/third_party/zlib.git",
++    )
 diff --git a/bazel/requirements.in b/bazel/requirements.in
 new file mode 100644
 index 0000000000..7f7afbf3bf
@@ -542,14 +535,14 @@ index 0000000000..a9c132f688
 +    --hash=sha256:fa130dd50c57d53368c9d59395cb5526eda596d3ffe36666cd81a44d56e48872
 +    # via jinja2
 diff --git a/src/inspector/BUILD.gn b/src/inspector/BUILD.gn
-index 495354da45..1473f30df0 100644
+index 495354da45..733fab3dff 100644
 --- a/src/inspector/BUILD.gn
 +++ b/src/inspector/BUILD.gn
 @@ -47,6 +47,8 @@ inspector_protocol_generate("protocol_generated_sources") {
 
    inspector_protocol_dir = _inspector_protocol
    out_dir = target_gen_dir
-+  _protocol_path=rebase_path(v8_inspector_js_protocol, root_build_dir)
++  _protocol_path = rebase_path(v8_inspector_js_protocol, root_build_dir)
 +  config_values = [ "protocol.path=$_protocol_path" ]
    config_file = v8_path_prefix + "/src/inspector/inspector_protocol_config.json"
    inputs = [

bazel/repositories.bzl

@@ -125,15 +125,15 @@ def proxy_wasm_cpp_host_repositories():
 
     git_repository(
         name = "v8",
-        commit = "3ac58d694cdcdc2a6e1420c06a955f64310c42f8",
+        commit = "8280a12b2bdf7c22235d44f27998d6de3b47a3bd",
         remote = "https://chromium.googlesource.com/v8/v8",
-        shallow_since = "1641210631 +0000",
+        shallow_since = "1641557155 +0000",
         patches = ["@proxy_wasm_cpp_host//bazel/external:v8.patch"],
         patch_args = ["-p1"],
     )
 
     new_git_repository(
-        name = "com_googlesource_chromium_trace_event_common",
+        name = "com_googlesource_chromium_base_trace_event_common",
         build_file = "@v8//:bazel/BUILD.trace_event_common",
         commit = "7f36dbc19d31e2aad895c60261ca8f726442bfbb",
         remote = "https://chromium.googlesource.com/chromium/src/base/trace_event/common.git",