Skip to content

Commit e2926f1

Browse files
committed
review: add /DEBUG:FULL on Windows.
Signed-off-by: Piotr Sikora <[email protected]>
1 parent 05c3677 commit e2926f1

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

bazel/external/v8.patch

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
# Set v8_enable_handle_zapping=False to regain performance.
1+
# 1. Set v8_enable_handle_zapping=False to regain performance.
2+
# 2. Fix linking on Windows.
23

34
diff --git a/BUILD.bazel b/BUILD.bazel
45
index 7d09243ee9..b9dec574e9 100644
@@ -13,3 +14,15 @@ index 7d09243ee9..b9dec574e9 100644
1314
)
1415

1516
v8_flag(name = "v8_enable_hugepage")
17+
diff --git a/bazel/defs.bzl b/bazel/defs.bzl
18+
index f162149f0a..8e2db11b48 100644
19+
--- a/bazel/defs.bzl
20+
+++ b/bazel/defs.bzl
21+
@@ -155,6 +155,7 @@ def _default_args():
22+
includes = ["include"],
23+
linkopts = select({
24+
"@v8//bazel/config:is_windows": [
25+
+ "/DEBUG:FULL"
26+
"Winmm.lib",
27+
"DbgHelp.lib",
28+
"Advapi32.lib",

0 commit comments

Comments
 (0)