Skip to content

Commit cb4cd3a

Browse files
authored
[llvm][AArch64] Fix an assertion message in TargetParserTests. NFC (llvm#98085)
For both overloads, we were printing the bit-pattern for ExpectedFlags twice. While we're here, also add a convenience line that highlights the difference between the two sets.
1 parent faa4e35 commit cb4cd3a

File tree

1 file changed

+13
-8
lines changed

1 file changed

+13
-8
lines changed

llvm/unittests/TargetParser/TargetParserTest.cpp

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -110,12 +110,14 @@ template <ARM::ISAKind ISAKind> struct AssertSameExtensionFlags {
110110
if (ExpectedFlags == GotFlags)
111111
return testing::AssertionSuccess();
112112

113-
return testing::AssertionFailure() << llvm::formatv(
114-
"CPU: {4}\n"
115-
"Expected extension flags: {0} ({1:x})\n"
116-
" Got extension flags: {2} ({3:x})\n",
117-
FormatExtensionFlags(ExpectedFlags), ExpectedFlags,
118-
FormatExtensionFlags(GotFlags), ExpectedFlags, CPUName);
113+
return testing::AssertionFailure()
114+
<< llvm::formatv("CPU: {4}\n"
115+
"Expected extension flags: {0} ({1:x})\n"
116+
" Got extension flags: {2} ({3:x})\n"
117+
" Diff: {5} ({6:x})\n",
118+
FormatExtensionFlags(ExpectedFlags), ExpectedFlags,
119+
FormatExtensionFlags(GotFlags), GotFlags, CPUName,
120+
FormatExtensionFlags(ExpectedFlags ^ GotFlags));
119121
}
120122

121123
testing::AssertionResult operator()(const char *m_expr, const char *n_expr,
@@ -127,11 +129,14 @@ template <ARM::ISAKind ISAKind> struct AssertSameExtensionFlags {
127129
return testing::AssertionFailure()
128130
<< llvm::formatv("CPU: {4}\n"
129131
"Expected extension flags: {0} ({1})\n"
130-
" Got extension flags: {2} ({3})\n",
132+
" Got extension flags: {2} ({3})\n"
133+
" Diff: {5} ({6})\n",
131134
FormatExtensionFlags(ExpectedFlags),
132135
SerializeExtensionFlags(ExpectedFlags),
133136
FormatExtensionFlags(GotFlags),
134-
SerializeExtensionFlags(ExpectedFlags), CPUName);
137+
SerializeExtensionFlags(GotFlags), CPUName,
138+
FormatExtensionFlags(ExpectedFlags ^ GotFlags),
139+
SerializeExtensionFlags(ExpectedFlags ^ GotFlags));
135140
}
136141

137142
private:

0 commit comments

Comments
 (0)