fix(spacing): default behaviour pixdim padding (#5248)

Fixes #4812 


### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: a-parida12 <[email protected]>
Signed-off-by: monai-bot <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: monai-bot <[email protected]>

Author: 3 people

monai/transforms/spatial/array.py

@@ -447,7 +447,8 @@ def __init__(
             pixdim: output voxel spacing. if providing a single number, will use it for the first dimension.
                 items of the pixdim sequence map to the spatial dimensions of input image, if length
                 of pixdim sequence is longer than image spatial dimensions, will ignore the longer part,
-                if shorter, will pad with `1.0`.
+                if shorter, will pad with the last value. For example, for 3D image if pixdim is [1.0, 2.0] it
+                will be padded to [1.0, 2.0, 2.0]
                 if the components of the `pixdim` are non-positive values, the transform will use the
                 corresponding components of the original pixdim, which is computed from the `affine`
                 matrix of input image.
@@ -574,7 +575,8 @@ def __call__(
 
         out_d = self.pixdim[:sr]
         if out_d.size < sr:
-            out_d = np.append(out_d, [1.0] * (sr - out_d.size))
+            out_d = np.append(out_d, [out_d[-1]] * (sr - out_d.size))
+
         orig_d = affine_to_spacing(affine_, sr, out_d.dtype)
         for idx, (_d, mn, mx) in enumerate(
             zip_longest(orig_d, self.min_pixdim[:sr], self.max_pixdim[:sr], fillvalue=np.nan)
@@ -588,6 +590,7 @@ def __call__(
 
         if not align_corners and scale_extent:
             warnings.warn("align_corners=False is not compatible with scale_extent=True.")
+
         # compute output affine, shape and offset
         new_affine = zoom_affine(affine_, out_d, diagonal=self.diagonal)
         scale_extent = self.scale_extent if scale_extent is None else scale_extent

tests/test_spacing.py

@@ -44,6 +44,16 @@
             *device,
         ]
     )
+    TESTS.append(
+        [
+            {"pixdim": 2.0, "padding_mode": "zeros", "dtype": float},
+            torch.arange(4).reshape((1, 2, 2)) + 1.0,  # data
+            torch.eye(4),
+            {},
+            torch.tensor([[[1.0, 0.0], [0.0, 0.0]]]),
+            *device,
+        ]
+    )
     TESTS.append(
         [
             {"pixdim": (1.0, 1.0, 1.0), "padding_mode": "zeros", "dtype": float},