Skip to content

4167 Enhance bundle parser when loading multiple config files #4192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 28, 2022

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Apr 28, 2022

Fixes #4167 .

Description

This PR enhanced the bundle parser logic when loading multiple config files, the previous logic only overrides the top-level keys in the config content, this PR made its logic to be consistent with ConfigParser set() logic.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 28, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Apr 28, 2022

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli April 28, 2022 03:11
@ericspod ericspod merged commit 05b9d31 into Project-MONAI:dev Apr 28, 2022
Can-Zhao pushed a commit to Can-Zhao/MONAI that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to enhance the logic control of bundle config
2 participants