Skip to content

SRS updates for handling incoming data #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Aug 5, 2022

Fixes #48.

Updates documentation and sequence diagrams for how incoming data are handled.

Whether pushed or pulled, data coming into the system are queued for upload to the configured storage service immediately.
IG no longer stores incoming data on the local disk. Therefore, queued data resides in system memory which may be a potential issue if the connection is slow between IG and the storage service. There are a few options to fix this issue but we will consider them in the future.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the documentation Improvements or additions to documentation label Aug 5, 2022
@mocsharp mocsharp added this to the 0.3.0 milestone Aug 5, 2022
@mocsharp mocsharp self-assigned this Aug 5, 2022
@mocsharp mocsharp changed the title Design changes for temporary storage SRS updates for handling incoming data Aug 5, 2022
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #112 (f5c26d2) into develop (2345730) will increase coverage by 0.00723%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #112         +/-   ##
===================================================
+ Coverage   93.39309%   93.40032%   +0.00722%     
===================================================
  Files            233         233                 
  Lines          13834       13834                 
  Branches         746         746                 
===================================================
+ Hits           12920       12921          +1     
+ Misses           674         673          -1     
  Partials         240         240                 
Flag Coverage Δ
unittests 93.40032% <ø> (+0.00722%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Gateway/Repositories/InferenceRequestRepository.cs 95.23810% <0.00000%> (+1.19048%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2345730...f5c26d2. Read the comment docs.

@mocsharp mocsharp merged commit 181c212 into develop Aug 8, 2022
@mocsharp mocsharp deleted the vchang/storage-docs branch August 8, 2022 17:28
@mocsharp mocsharp modified the milestones: 0.3.0, 0.2.0 Aug 16, 2022
mocsharp added a commit that referenced this pull request Aug 19, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Development

Successfully merging this pull request may close these issues.

Allow customizing temporary storage to use storage service
2 participants