Skip to content

Refactor database projects to support multiple database types #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 8, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Nov 3, 2022

Description

  • Refactors existing sqlite support to new projects to allow the use of other DB types

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the enhancement Enhancement to existing feature label Nov 3, 2022
@mocsharp mocsharp added this to the 0.3.4 milestone Nov 3, 2022
@mocsharp mocsharp self-assigned this Nov 3, 2022
@mocsharp mocsharp changed the base branch from develop to vchang/security November 3, 2022 00:30
@mocsharp mocsharp changed the title Support MongDB Refactor database projects to support multiple database types Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #237 (ba0ce5c) into develop (09c8901) will decrease coverage by 5.64438%.
The diff coverage is 29.03226%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #237         +/-   ##
===================================================
- Coverage   92.81785%   87.17347%   -5.64439%     
===================================================
  Files            273         276          +3     
  Lines          16179       16193         +14     
  Branches         830         835          +5     
===================================================
- Hits           15017       14116        -901     
- Misses           906        1819        +913     
- Partials         256         258          +2     
Flag Coverage Δ
unittests 87.17347% <29.03226%> (-5.64439%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Configuration/InformaticsGatewayConfiguration.cs 100.00000% <ø> (ø)
src/Database/DatabaseMigrationManager.cs 0.00000% <0.00000%> (ø)
...ation/DestinationApplicationEntityConfiguration.cs 100.00000% <ø> (ø)
...ork/Configuration/InferenceRequestConfiguration.cs 100.00000% <ø> (ø)
...nfiguration/MonaiApplicationEntityConfiguration.cs 100.00000% <ø> (ø)
...ityFramework/Configuration/PayloadConfiguration.cs 100.00000% <ø> (ø)
...figuration/SourceApplicationEntityConfiguration.cs 100.00000% <ø> (ø)
...ation/StorageMetadataWrapperEntityConfiguration.cs 100.00000% <ø> (ø)
...base/EntityFramework/EfDatabaseMigrationManager.cs 0.00000% <0.00000%> (ø)
...abase/EntityFramework/InformaticsGatewayContext.cs 100.00000% <ø> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c83c50a...ba0ce5c. Read the comment docs.

Base automatically changed from vchang/security to develop November 8, 2022 16:59
@mocsharp mocsharp merged commit 697c7fc into develop Nov 8, 2022
@mocsharp mocsharp deleted the gh-235 branch November 8, 2022 18:50
@github-actions
Copy link

🎉 This issue has been resolved in version 0.3.4 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
Development

Successfully merging this pull request may close these issues.

2 participants