Skip to content

Enable nuget cache on build workflow #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 9, 2022
Merged

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Feb 9, 2022

Fixes #42 .

Description

Enable nuget cache and integrate code-ql scan.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests-in-docker.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the build Build & build workflow label Feb 9, 2022
@mocsharp mocsharp added this to the 0.1.0 milestone Feb 9, 2022
@mocsharp mocsharp self-assigned this Feb 9, 2022
@mocsharp mocsharp changed the title Vchang/release action Enable nuget cache on build workflow Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #53 (99e5eac) into main (ecb1854) will increase coverage by 0.06822%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main         #53         +/-   ##
===================================================
+ Coverage   88.26739%   88.33561%   +0.06821%     
===================================================
  Files            161         161                 
  Lines           7330        7330                 
  Branches         558         558                 
===================================================
+ Hits            6470        6475          +5     
+ Misses           684         681          -3     
+ Partials         176         174          -2     
Flag Coverage Δ
unittests 88.33561% <ø> (+0.06821%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ateway/Services/Connectors/DataRetrievalService.cs 88.60294% <0.00000%> (+0.73529%) ⬆️
...Gateway/Repositories/InferenceRequestRepository.cs 97.64706% <0.00000%> (+3.52940%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb1854...99e5eac. Read the comment docs.

@mocsharp mocsharp requested a review from evberrypi February 9, 2022 00:31
Copy link

@evberrypi evberrypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense.

@mocsharp mocsharp merged commit 20cd123 into main Feb 9, 2022
@mocsharp mocsharp deleted the vchang/release_action branch February 9, 2022 00:42
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

🎉 This issue has been resolved in version 0.1.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build & build workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Create Release pipeline
2 participants