Skip to content

Enable SonarCloud #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2022
Merged

Enable SonarCloud #64

merged 1 commit into from
Mar 11, 2022

Conversation

mocsharp
Copy link
Collaborator

Description

Enable SonarCloud for code scanning

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests-in-docker.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the build Build & build workflow label Mar 11, 2022
@mocsharp mocsharp added this to the 0.2.0 milestone Mar 11, 2022
@mocsharp mocsharp requested a review from evberrypi March 11, 2022 20:09
@mocsharp mocsharp self-assigned this Mar 11, 2022
@mocsharp mocsharp force-pushed the vchang/sonar-cloud branch from af151e6 to 71fbb73 Compare March 11, 2022 20:09
@codecov
Copy link

codecov bot commented Mar 11, 2022 •
edited
Loading

Codecov Report

Merging #64 (710191a) into develop (eef9c7e) will increase coverage by 0.01627%.
The diff coverage is n/a.

❗ Current head 710191a differs from pull request most recent head e5cd1bc. Consider uploading reports for the commit e5cd1bc to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop         #64         +/-   ##
===================================================
+ Coverage   92.57542%   92.59169%   +0.01627%     
===================================================
  Files            203         203                 
  Lines          12297       12297                 
  Branches         622         622                 
===================================================
+ Hits           11384       11386          +2     
+ Misses           730         729          -1     
+ Partials         183         182          -1
Flag Coverage Δ
unittests 92.59169% <ø> (+0.01627%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Test/Services/Storage/SpaceReclaimerServiceTest.cs 100.00000% <0.00000%> (+2.22221%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef9c7e...e5cd1bc. Read the comment docs.

@mocsharp mocsharp force-pushed the vchang/sonar-cloud branch 7 times, most recently from 8708713 to 710191a Compare March 11, 2022 21:34
evberrypi
evberrypi reviewed Mar 11, 2022
View reviewed changes
.github/workflows/ci.yml Outdated
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: � 2021-2022 MONAI Consortium
# SPDX-FileCopyrightText: � 2021-2022 MONAI Consortium
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened to the copyright?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@mocsharp
Enable SonarCloud
e5cd1bc 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp force-pushed the vchang/sonar-cloud branch from 710191a to e5cd1bc Compare March 11, 2022 22:21
evberrypi
evberrypi approved these changes Mar 11, 2022
View reviewed changes
Copy link

@evberrypi evberrypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mocsharp mocsharp merged commit 0c9b358 into develop Mar 11, 2022
@mocsharp mocsharp deleted the vchang/sonar-cloud branch March 11, 2022 22:23
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evberrypi evberrypi evberrypi approved these changes

Assignees

@mocsharp mocsharp

Labels
build Build & build workflow
Projects
Clinical Data Pipelines
Status: Done
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mocsharp @evberrypi