Skip to content

Update Monai.Deploy.Messaging & Monai.Deploy.Storage to 0.1 official … #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Jun 29, 2022

Description

Update Monai.Deploy.Messaging & Monai.Deploy.Storage to 0.1 official builds

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the build Build & build workflow label Jun 29, 2022
@mocsharp mocsharp added this to the 0.2.0 milestone Jun 29, 2022
@mocsharp mocsharp requested a review from jackschofield23 June 29, 2022 04:56
@mocsharp mocsharp self-assigned this Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #96 (6c31ef5) into develop (4f43589) will decrease coverage by 0.03786%.
The diff coverage is 94.59459%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop         #96         +/-   ##
===================================================
- Coverage   93.68161%   93.64375%   -0.03787%     
===================================================
  Files            222         222                 
  Lines          13342       13294         -48     
  Branches         703         702          -1     
===================================================
- Hits           12499       12449         -50     
- Misses           611         612          +1     
- Partials         232         233          +1     
Flag Coverage Δ
unittests 93.64375% <94.59459%> (-0.03787%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/CLI/Commands/DestinationCommand.cs 98.34711% <ø> (ø)
src/CLI/Commands/SourceCommand.cs 98.30508% <ø> (ø)
src/CLI/Commands/StartCommand.cs 100.00000% <ø> (ø)
src/CLI/Commands/StatusCommand.cs 100.00000% <ø> (ø)
src/CLI/Commands/StopCommand.cs 100.00000% <ø> (ø)
src/Client/Services/HealthService.cs 100.00000% <ø> (ø)
src/InformaticsGateway/Test/DummyStorageService.cs 14.28571% <0.00000%> (ø)
...maticsGateway/Services/Export/ExportServiceBase.cs 86.45161% <100.00000%> (-0.42339%) ⬇️
.../Test/Services/Export/DicomWebExportServiceTest.cs 100.00000% <100.00000%> (ø)
...eway/Test/Services/Export/ExportServiceBaseTest.cs 98.05195% <100.00000%> (-0.08470%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f43589...6c31ef5. Read the comment docs.

Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp requested a review from a team June 30, 2022 16:55
@mocsharp mocsharp merged commit 59b76b2 into develop Jun 30, 2022
@mocsharp mocsharp deleted the vchang/update-libs branch June 30, 2022 17:26
mocsharp added a commit that referenced this pull request Aug 19, 2022
#96)

* Update Monai.Deploy.Messaging & Monai.Deploy.Storage to 0.1 official builds
* Update storage GetObjectAsync call

Signed-off-by: Victor Chang <[email protected]>
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build & build workflow
Projects
Development

Successfully merging this pull request may close these issues.

2 participants