Skip to content

Auto3DSeg notebook and tutorial documentation improvements #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Nov 24, 2022

Conversation

mingxin-zheng
Copy link
Contributor

Fixes # 1047.

Description

  • Fix HPO overriding parameters doesn't work for DiNTS in NNI
  • Fix documentation issues, such as typo, bad sentences,
  • Auto3DSeg notebook running failures on 8-GPU machine
  • Update the notebook writing style to match other MONAI tutorials

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mingxin-zheng mingxin-zheng requested a review from wyli November 24, 2022 18:28
@wyli wyli enabled auto-merge (squash) November 24, 2022 19:51
@wyli wyli merged commit 47033b5 into Project-MONAI:main Nov 24, 2022
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
…ONAI#1065)

Fixes # 1047.

### Description

- Fix HPO overriding parameters doesn't work for DiNTS in NNI
- Fix documentation issues, such as typo, bad sentences, 
- Auto3DSeg notebook running failures on 8-GPU machine
- Update the notebook writing style to match other MONAI tutorials

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Notebook runs automatically `./runner [-p <regex_pattern>]`

Signed-off-by: Mingxin Zheng <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants