Skip to content

Fix evaluation in HoVerNet tutorial #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Dec 28, 2022
Merged

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Dec 28, 2022

Part of #5774.

Description

Add EnsureChannelFirstd
Update to argmax

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

KumoLiu and others added 28 commits July 21, 2022 10:22
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu KumoLiu requested review from bhashemian and Nic-Ma December 28, 2022 02:52
@KumoLiu KumoLiu requested a review from wyli December 28, 2022 02:52
@mingxin-zheng
Copy link
Contributor

Hi @KumoLiu , the file lacks the licensing info. Can you add the following to the top of the script? Thanks!

# Copyright (c) MONAI Consortium
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#     http://www.apache.org/licenses/LICENSE-2.0
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

Signed-off-by: KumoLiu <[email protected]>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Dec 28, 2022

Hi @KumoLiu , the file lacks the licensing info. Can you add the following to the top of the script? Thanks!

Hi @mingxin-zheng, have added it, thanks!

@mingxin-zheng
Copy link
Contributor

Thanks @KumoLiu !

@KumoLiu KumoLiu merged commit f87bb12 into Project-MONAI:main Dec 28, 2022
@KumoLiu KumoLiu deleted the pathology branch December 28, 2022 10:14
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Part of [#5774](Project-MONAI/MONAI#5774).

### Description
Add `EnsureChannelFirstd`
Update to argmax

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Notebook runs automatically `./runner [-p <regex_pattern>]`

Signed-off-by: KumoLiu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants