Skip to content

1161 update model zoo and competitions #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yiheng-wang-nv
Copy link
Contributor

Signed-off-by: Yiheng Wang [email protected]

Fixes #1161 .

Description

This PR add updates of tutorials in competitions and model_zoo according to the requirements of the contributing guide.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Yiheng Wang <[email protected]>
Copy link
Contributor

@mingxin-zheng mingxin-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Can you create titles # Title in the first markdown cell of the following notebooks? Thanks!

  • preprocess_detect_scene_and_split_fold.ipynb
  • preprocess_extract_images_from_video.ipynb
  • preprocess_to_build_detection_dataset.ipynb

@mingxin-zheng mingxin-zheng enabled auto-merge (squash) January 19, 2023 05:51
@mingxin-zheng mingxin-zheng merged commit 1cb8f69 into Project-MONAI:main Jan 19, 2023
@yiheng-wang-nv yiheng-wang-nv deleted the 1161-update-model-zoo-competitions branch January 19, 2023 06:18
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Signed-off-by: Yiheng Wang <[email protected]>

Fixes Project-MONAI#1161 .

### Description
This PR add updates of tutorials in `competitions` and `model_zoo`
according to the requirements of the contributing guide.

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Avoid including large-size files in the PR.
- [x] Clean up long text outputs from code cells in the notebook.
- [x] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [x] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

Signed-off-by: Yiheng Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tutorials according to new requirements
2 participants