Skip to content

adds model_zoo/TCIA_PROSTATEx_Prostate_MRI_Anatomy_Model.ipynb #1185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 26, 2023

Conversation

kirbyju
Copy link
Contributor

@kirbyju kirbyju commented Jan 20, 2023

Description

I made the summary more focused on the specific prostate dataset and model being used and also consolidated the setup steps (installations/imports) at the top.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Nic-Ma Nic-Ma requested a review from wyli January 22, 2023 02:13
@wyli wyli mentioned this pull request Jan 23, 2023
5 tasks
@wyli wyli force-pushed the tcia-prostate-model-zoo branch from 8d90cc9 to 53633d4 Compare January 23, 2023 09:54
@wyli wyli changed the title Cleanup and improved summary adds model_zoo/TCIA_PROSTATEx_Prostate_MRI_Anatomy_Model.ipynb Jan 23, 2023
kirbyju and others added 5 commits January 23, 2023 09:57
Signed-off-by: Wenqi Li <[email protected]>
stdin:154:1: F821 undefined name 'display'
display(df)

Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the tcia-prostate-model-zoo branch from 53633d4 to 7632810 Compare January 23, 2023 09:58
wyli added 6 commits January 23, 2023 10:09
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the tcia-prostate-model-zoo branch from e457c93 to 130f6ac Compare January 23, 2023 10:46
@wyli
Copy link
Contributor

wyli commented Jan 23, 2023

thanks @kirbyju, now the tests work fine, I mainly

  • added a license cell
  • updated the import statements (removed most of the --pre flag)
  • removed display(df) as it raises an error "stdin:154:1: F821 undefined name 'display'
    display(df)"

please help confirm those changes.

@wyli wyli requested a review from mingxin-zheng January 23, 2023 10:57
@kirbyju
Copy link
Contributor Author

kirbyju commented Jan 25, 2023

Looks good to me. Should I close this pull request or is there something else that needs to happen to complete the merge?

@wyli
Copy link
Contributor

wyli commented Jan 25, 2023

thanks, let's wait for Mingxin's review, then I'll update and merge it.

@kirbyju
Copy link
Contributor Author

kirbyju commented Jan 26, 2023

On Google Colab I get the following warnings/errors when I run the Setup step, but it still seems to let me run all of the subsequent steps in the notebook successfully so maybe it's not a problem?

Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'monai'
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
pydicom-seg 0.4.0 requires jsonschema<4.0.0,>=3.2.0, but you have jsonschema 4.17.3 which is incompatible.
google-colab 1.0.0 requires notebook~=5.7.16, but you have notebook 6.5.2 which is incompatible.
google-colab 1.0.0 requires tornado~=6.0.4, but you have tornado 6.2 which is incompatible.
flask 1.1.4 requires Jinja2<3.0,>=2.10.1, but you have jinja2 3.1.2 which is incompatible.

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I'm merging this for now, please feel free to raise new PRs to revise it.

@wyli wyli enabled auto-merge (squash) January 26, 2023 19:37
@wyli wyli merged commit 7e2494c into Project-MONAI:main Jan 26, 2023
@kirbyju kirbyju deleted the tcia-prostate-model-zoo branch January 26, 2023 19:53
@mingxin-zheng mingxin-zheng mentioned this pull request Jan 27, 2023
5 tasks
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants