-
Notifications
You must be signed in to change notification settings - Fork 739
adds model_zoo/TCIA_PROSTATEx_Prostate_MRI_Anatomy_Model.ipynb #1185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
8d90cc9
to
53633d4
Compare
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
stdin:154:1: F821 undefined name 'display' display(df) Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
53633d4
to
7632810
Compare
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
e457c93
to
130f6ac
Compare
thanks @kirbyju, now the tests work fine, I mainly
please help confirm those changes. |
Looks good to me. Should I close this pull request or is there something else that needs to happen to complete the merge? |
thanks, let's wait for Mingxin's review, then I'll update and merge it. |
On Google Colab I get the following warnings/errors when I run the Setup step, but it still seems to let me run all of the subsequent steps in the notebook successfully so maybe it's not a problem?
|
Signed-off-by: Wenqi Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I'm merging this for now, please feel free to raise new PRs to revise it.
Description
I made the summary more focused on the specific prostate dataset and model being used and also consolidated the setup steps (installations/imports) at the top.
Checks
./figure
folder./runner.sh -t <path to .ipynb file>