Skip to content

update url #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2023
Merged

update url #1190

merged 2 commits into from
Jan 27, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jan 26, 2023

Signed-off-by: Wenqi Li [email protected]

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from mingxin-zheng and Nic-Ma January 26, 2023 19:44
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wyli
Copy link
Contributor Author

wyli commented Jan 27, 2023

this notebook breaks the guidelines test, but the code cells looks good to me... @mingxin-zheng

@mingxin-zheng
Copy link
Contributor

Hi @wyli , the guidelines test did not pass because

Error: Missing the "Setup imports" after the first code cell of file: /home/runner/work/tutorials/tutorials/model_zoo/TCIA_PROSTATEx_Prostate_MRI_Anatomy_Model.ipynb.

In this notebook, there is an extra markdown cell "## Setup the im-joy-jupyter-extension for itkWidgets" between the code of env setup and "## Setup import", which is not accepted by the test.

If there will be notebooks in this style in the future, we can merge the "## Setup the im-joy-jupyter-extension for itkWidgets" and "## Setup imports" into one markdown cell as a hack, and update the runner.sh in another PR to fix this.

If this is a special case, as mentioned in this message, putting it with the "## Setup environment" cell may be better.

@wyli wyli merged commit 6b10acb into Project-MONAI:main Jan 27, 2023
@wyli wyli deleted the update-url branch January 27, 2023 08:12
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Signed-off-by: Wenqi Li <[email protected]>


### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Avoid including large-size files in the PR.
- [ ] Clean up long text outputs from code cells in the notebook.
- [ ] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

Signed-off-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants