Skip to content

MONAILabel: Detection and Whole Body Seg Tutorials #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 17, 2023

Conversation

tangy5
Copy link
Contributor

@tangy5 tangy5 commented Mar 7, 2023

Add Detection and Whole Body Seg Tutorials to monailabel

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tangy5 tangy5 requested review from wyli and mingxin-zheng March 7, 2023 04:20
@tangy5
Copy link
Contributor Author

tangy5 commented Mar 17, 2023

Hi @wyli @mingxin-zheng , I have verified the two new notebooks, could you have a look? If no problem, we can merge this.
Thank you so much!

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I can't remember why we create juypter notebooks for these documentations instead of simpler markdown files. most of them are CLI commands, I don't see how jupyter notebook makes it easier to use...cc @mingxin-zheng

@wyli wyli merged commit ab71204 into Project-MONAI:main Mar 17, 2023
@tangy5
Copy link
Contributor Author

tangy5 commented Mar 17, 2023

looks good to me, I can't remember why we create juypter notebooks for these documentations instead of simpler markdown files. most of them are CLI commands, I don't see how jupyter notebook makes it easier to use...cc @mingxin-zheng

Good point, these notebooks ideas come from the dev plan of Toolkit, then we decide to make these commands in the notebook, so that users can play with it. Another thoughts is that, in the future, these notebooks will sync with MONAI Toolkit, if markdown is better, we can quickly convert. Open discussions.

boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Add Detection and Whole Body Seg Tutorials to monailabel

---------

Signed-off-by: tangy5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants