-
Notifications
You must be signed in to change notification settings - Fork 739
adds a lazy resampling functional example #1254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Wenqi Li <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
…ctional Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
View / edit / reply to this conversation on ReviewNB KumoLiu commented on 2023-03-19T10:15:23Z Line #7. I think we could also add |
View / edit / reply to this conversation on ReviewNB KumoLiu commented on 2023-03-19T10:15:24Z Line #12. rand_windows.set_random_state(0)
May I ask why we both need set set_determinism(1234) and |
View / edit / reply to this conversation on ReviewNB KumoLiu commented on 2023-03-19T10:15:25Z Line #2. We could also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just leave some comments in line, feel free to ignore them, thanks!
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
part of Project-MONAI/MONAI#6156 ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [x] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: Wenqi Li <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
part of Project-MONAI/MONAI#6156
Checks
./figure
folder./runner.sh -t <path to .ipynb file>