Skip to content

stdin:107:17: C416 Unnecessary dict comprehension - rewrite using dict() #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Mar 18, 2023

Running ./microscopy/multichannel_microscopy_classification.ipynb
Checking PEP8 compliance...
stdin:107:17: C416 Unnecessary dict comprehension - rewrite using dict().
class_map_inv = {idx: c for idx, c in enumerate(dftrain.cell_type.unique())}
                ^
Error: Try running with autofixes: --autofix.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

wyli added 2 commits March 18, 2023 10:44
class_map_inv = {idx: c for idx, c in enumerate(dftrain.cell_type.unique())}
                ^
Error: Try running with autofixes: --autofix.
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wyli wyli marked this pull request as ready for review March 18, 2023 10:53
@wyli wyli merged commit 02911a9 into Project-MONAI:main Mar 18, 2023
@wyli wyli deleted the fixes-premerges branch March 30, 2023 21:20
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants