Skip to content

Update GDS end-to-end figure #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Jul 20, 2023

Description

The last figure may cause confusion since GDS may not affect performance. The reason why it shows GDS looks needs fewer epochs to achieve the same result is that the training didn't set deterministic, so there may be little difference. Remove the last figure.

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: KumoLiu <[email protected]>
@KumoLiu KumoLiu requested review from wyli, ericspod and Nic-Ma July 20, 2023 06:18
@KumoLiu KumoLiu merged commit dc83e06 into Project-MONAI:main Jul 20, 2023
@KumoLiu KumoLiu deleted the gds-tutorial branch July 20, 2023 06:26
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
### Description
The last figure may cause confusion since GDS may not affect
performance. The reason why it shows GDS looks needs fewer epochs to
achieve the same result is that the training didn't set deterministic,
so there may be little difference. Remove the last figure.

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Avoid including large-size files in the PR.
- [ ] Clean up long text outputs from code cells in the notebook.
- [ ] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

Signed-off-by: KumoLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants