Skip to content

Split PR and add Maisi find mask script #1751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 4, 2024

Conversation

Can-Zhao
Copy link
Contributor

@Can-Zhao Can-Zhao commented Jul 3, 2024

Fixes # .

Description

Split PR and add Maisi find mask script

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

@Can-Zhao Can-Zhao marked this pull request as ready for review July 3, 2024 20:17
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@KumoLiu KumoLiu requested review from ericspod and Nic-Ma July 4, 2024 05:16
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update, looks good to me.

If you don't have any other comments, I will merge this one. cc @Nic-Ma @mingxin-zheng

@KumoLiu KumoLiu merged commit 4ad30a6 into Project-MONAI:main Jul 4, 2024
6 checks passed
@Can-Zhao Can-Zhao deleted the masi_find_mask branch July 4, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants