Skip to content

21 add DICOM format in the LoadImage tutorial #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2020
Merged

21 add DICOM format in the LoadImage tutorial #23

merged 3 commits into from
Sep 17, 2020

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Sep 16, 2020

This PR updated the load medical image tutorial to support DICOM format.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Nic-Ma, a few questions:

  • could you add a multi-channel example from multiple DICOM files
  • does it support loading a folder of dcm files
  • could you change the example shape (128 128 128) to something like (128, 128, 96)? so that we could identify the shape issues easily if there's any

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Sep 16, 2020

Hi @wyli ,

Thanks for your review.
I updated the PR according to your review, loading DICOM in a folder is another PR in MONAI core repo.
Could you please help review it again?

Thanks.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Sep 17, 2020

Hi @wyli and @ericspod ,

As we fixed ITK shape issue in PR: Project-MONAI/MONAI#1045, updated the notebook here.
This PR is ready for review now.

Thanks.

@wyli wyli merged commit 2bb5311 into master Sep 17, 2020
@Nic-Ma Nic-Ma deleted the 21-load-dicom branch September 18, 2020 01:47
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
* [DLMED] add DICOM format in the tutorial

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update ITK shape

Signed-off-by: Nic Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants