Skip to content

Add DeepEdit Bundle #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Conversation

diazandr3s
Copy link
Contributor

Signed-off-by: Andres Diaz-Pinto [email protected]

DeepEdit Bundle

Signed-off-by: Andres Diaz-Pinto <[email protected]>
@diazandr3s diazandr3s requested a review from Nic-Ma May 10, 2022 12:38
@diazandr3s diazandr3s requested a review from yiheng-wang-nv May 10, 2022 12:38
@diazandr3s
Copy link
Contributor Author

diazandr3s commented May 10, 2022

@Nic-Ma how I can send a dictionary to a transform?

When using this transform here

https://github.com/Project-MONAI/MONAI/blob/dev/monai/apps/deepedit/transforms.py#L101

I'm getting this error:

for idx, (key_label, val_label) in enumerate(self.label_names.items(), start=1):

AttributeError: 'str' object has no attribute 'items'

It seems the transform is getting a str instead of a dictionary :/

@Nic-Ma
Copy link
Contributor

Nic-Ma commented May 10, 2022

@Nic-Ma how I can send a dictionary to a transform?

When using this transform here

https://github.com/Project-MONAI/MONAI/blob/dev/monai/apps/deepedit/transforms.py#L101

I'm getting this error:

for idx, (key_label, val_label) in enumerate(self.label_names.items(), start=1):

AttributeError: 'str' object has no attribute 'items'

It seems the transform is getting a str instead of a dictionary :/

Hi @diazandr3s ,

I think you should define the label_names as a dict in the JSON config instead of a string. For example:

"label_names": {"spleen": 1, "background": 0}

Thanks.

@diazandr3s diazandr3s changed the title [WIP] Add DeepEdit Bundle Add DeepEdit Bundle May 12, 2022
@diazandr3s
Copy link
Contributor Author

Closing this PR.
A new one has been created here: Project-MONAI/model-zoo#3

@diazandr3s diazandr3s closed this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants