Skip to content

Commit 2a883a2

Browse files
authored
Ensure when tag text is None that it is converted to empty string
Fixes #1049
1 parent 6b6cd8b commit 2a883a2

File tree

3 files changed

+21
-0
lines changed

3 files changed

+21
-0
lines changed

docs/change_log/index.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Python-Markdown Change Log
66
Under development: version 3.3.3 (a bug-fix release).
77

88
* Unify all block-level tags (#1047).
9+
* Fix issue where some empty elements would have text rendered as `None` when using `md_in_html` (#1049).
910

1011
Oct 19, 2020: version 3.3.2 (a bug-fix release).
1112

markdown/extensions/md_in_html.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,8 @@ def parse_element_content(self, element):
260260

261261
else:
262262
# Disable inline parsing for everything else
263+
if element.text is None:
264+
element.text = ''
263265
element.text = util.AtomicString(element.text)
264266
for child in list(element):
265267
self.parse_element_content(child)

tests/test_syntax/extensions/test_md_in_html.py

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -390,6 +390,24 @@ def test_md1_nested_empty_block(self):
390390
)
391391
)
392392

393+
def test_empty_tags(self):
394+
self.assertMarkdownRenders(
395+
self.dedent(
396+
"""
397+
<div markdown="1">
398+
<div></div>
399+
</div>
400+
"""
401+
),
402+
self.dedent(
403+
"""
404+
<div>
405+
<div></div>
406+
</div>
407+
"""
408+
)
409+
)
410+
393411
def test_orphan_end_tag_in_raw_html(self):
394412
self.assertMarkdownRenders(
395413
self.dedent(

0 commit comments

Comments
 (0)