Merge pull request matplotlib#29382 from rcomer/fix-polar-title

Fix title position for polar plots

Author: scottshambaugh

lib/matplotlib/axes/_base.py

@@ -3068,9 +3068,8 @@ def _update_title_position(self, renderer):
         top = -np.inf
         for ax in axs:
             bb = None
-            xticklabel_top = any(tick.label2.get_visible() for tick in
-                                 [ax.xaxis.majorTicks[0], ax.xaxis.minorTicks[0]])
-            if (xticklabel_top or ax.xaxis.get_label_position() == 'top'):
+            if (ax.xaxis.get_ticks_position() in ['top', 'unknown'] or
+                    ax.xaxis.get_label_position() == 'top'):
                 bb = ax.xaxis.get_tightbbox(renderer)
             if bb is None:
                 # Extent of the outline for colorbars, of the axes otherwise.

lib/matplotlib/tests/baseline_images/test_polar/polar_title_position.png

@@ -220,6 +220,13 @@ def test_polar_rlabel_position():
     ax.tick_params(rotation='auto')
 
 
+@image_comparison(['polar_title_position.png'], style='mpl20')
+def test_polar_title_position():
+    fig = plt.figure()
+    ax = fig.add_subplot(projection='polar')
+    ax.set_title('foo')
+
+
 @image_comparison(['polar_theta_wedge'], style='default')
 def test_polar_theta_limits():
     r = np.arange(0, 3.0, 0.01)