Skip to content

Commit ec5316f

Browse files
committed
ci: Fix testing without LTO
The jobs matrix doesn't set any environment variables, so the without-LTO job just set `CFLAGS` in the matrix, which was never used for anything as intended.
1 parent 5510383 commit ec5316f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
"ipython==7.29.0"
6666
"ipykernel==5.5.6"
6767
"matplotlib-inline<0.1.7"
68-
CFLAGS: "-fno-lto" # Ensure that disabling LTO works.
68+
lto: "--config-settings=setup-args=-Db_lto=false" # Ensure that disabling LTO works.
6969
# https://github.com/matplotlib/matplotlib/pull/26052#issuecomment-1574595954
7070
# https://www.riverbankcomputing.com/pipermail/pyqt/2023-November/045606.html
7171
pyqt6-ver: '!=6.5.1,!=6.6.0,!=6.7.1'
@@ -348,7 +348,7 @@ jobs:
348348
fi
349349
350350
python -m pip install --no-deps --no-build-isolation --verbose \
351-
--config-settings=setup-args="-DrcParams-backend=Agg" \
351+
--config-settings=setup-args="-DrcParams-backend=Agg" ${{ matrix.lto }} \
352352
--editable .[dev]
353353
354354
if [[ "${{ runner.os }}" != 'macOS' ]]; then

0 commit comments

Comments
 (0)