Skip to content

Commit 69e657a

Browse files
committed
TST: unxfail tests of out and dtype as positional args
1 parent b3d5f0a commit 69e657a

File tree

4 files changed

+1
-4
lines changed

4 files changed

+1
-4
lines changed

torch_np/tests/numpy_tests/core/test_multiarray.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3743,7 +3743,6 @@ def test_ret_is_out(self, ndim, method):
37433743
ret = arg_method(axis=0, out=out)
37443744
assert ret is out
37453745

3746-
@pytest.mark.xfail(reason='FIXME: out w/ positional args?')
37473746
@pytest.mark.parametrize('arr_method, np_method',
37483747
[('argmax', np.argmax),
37493748
('argmin', np.argmin)])

torch_np/tests/numpy_tests/core/test_numeric.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2486,7 +2486,6 @@ def test_mode(self):
24862486

24872487
class TestDtypePositional:
24882488

2489-
@pytest.mark.xfail(reason='TODO: restore dtypes as positional args')
24902489
def test_dtype_positional(self):
24912490
np.empty((2,), bool)
24922491

torch_np/tests/numpy_tests/lib/test_shape_base_.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -719,7 +719,7 @@ def test_kroncompare(self):
719719
for s in shape:
720720
b = randint(0, 10, size=s)
721721
for r in reps:
722-
a = np.ones(r, dtype=b.dtype) # TODO: restore dtype positional arg
722+
a = np.ones(r, b.dtype)
723723
large = tile(b, r)
724724
klarge = kron(a, b)
725725
assert_equal(large, klarge)

torch_np/tests/test_ndarray_methods.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,6 @@ def test_np_vs_ndarray(self, arr_method, np_method):
323323
assert_equal(arg_method(out=out1, axis=0), np_method(a, out=out2, axis=0))
324324
assert_equal(out1, out2)
325325

326-
@pytest.mark.xfail(reason="out=... as a positional arg")
327326
@pytest.mark.parametrize(
328327
"arr_method, np_method", [("argmax", np.argmax), ("argmin", np.argmin)]
329328
)

0 commit comments

Comments
 (0)