Skip to content

Commit 2e0c50c

Browse files
dimaspiritdimaspirit
committed
review another modules
1 parent 5462a0f commit 2e0c50c

File tree

4 files changed

+45
-54
lines changed

4 files changed

+45
-54
lines changed

‎js/modules/webrtc/qbWebRTCSignalingConstants.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
1-
/*
1+
/**
22
* QuickBlox JavaScript SDK
3-
*
43
* WebRTC Module (WebRTC signaling constants)
5-
*
64
*/
75

8-
function WebRTCSignalingConstants() {
9-
10-
}
6+
function WebRTCSignalingConstants() {}
117

128
WebRTCSignalingConstants.MODULE_ID = "WebRTCVideoChat";
139

@@ -20,4 +16,4 @@ WebRTCSignalingConstants.SignalingType = {
2016
PARAMETERS_CHANGED: 'update'
2117
};
2218

23-
module.exports = WebRTCSignalingConstants;
19+
module.exports = WebRTCSignalingConstants;

‎js/modules/webrtc/qbWebRTCSignalingProcessor.js

Lines changed: 25 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,20 @@
1-
/*
1+
/**
22
* QuickBlox JavaScript SDK
3-
*
43
* WebRTC Module (WebRTC signaling provider)
5-
*
64
*/
75

86
require('../../../lib/strophe/strophe.min');
7+
98
var Helpers = require('./qbWebRTCHelpers');
109
var SignalingConstants = require('./qbWebRTCSignalingConstants');
1110

1211
function WebRTCSignalingProcessor(service, delegate, connection) {
13-
this.service = service;
14-
this.delegate = delegate;
15-
this.connection = connection;
16-
1712
var self = this;
1813

14+
self.service = service;
15+
self.delegate = delegate;
16+
self.connection = connection;
17+
1918
this._onMessage = function(stanza) {
2019
var from = stanza.getAttribute('from');
2120
var extraParams = stanza.querySelector('extraParams');
@@ -30,7 +29,7 @@ function WebRTCSignalingProcessor(service, delegate, connection) {
3029
var sessionId = extension.sessionID;
3130
var signalType = extension.signalType;
3231

33-
// cleanup
32+
/** cleanup */
3433
delete extension.moduleIdentifier;
3534
delete extension.sessionID;
3635
delete extension.signalType;
@@ -40,42 +39,43 @@ function WebRTCSignalingProcessor(service, delegate, connection) {
4039
if (typeof self.delegate._onCallListener === 'function'){
4140
self.delegate._onCallListener(userId, sessionId, extension);
4241
}
43-
4442
break;
43+
4544
case SignalingConstants.SignalingType.ACCEPT:
4645
if (typeof self.delegate._onAcceptListener === 'function'){
4746
self.delegate._onAcceptListener(userId, sessionId, extension);
4847
}
49-
5048
break;
49+
5150
case SignalingConstants.SignalingType.REJECT:
5251
if (typeof self.delegate._onRejectListener === 'function'){
5352
self.delegate._onRejectListener(userId, sessionId, extension);
5453
}
55-
5654
break;
55+
5756
case SignalingConstants.SignalingType.STOP:
5857
if (typeof self.delegate._onStopListener === 'function'){
5958
self.delegate._onStopListener(userId, sessionId, extension);
6059
}
61-
6260
break;
61+
6362
case SignalingConstants.SignalingType.CANDIDATE:
6463
if (typeof self.delegate._onIceCandidatesListener === 'function'){
6564
self.delegate._onIceCandidatesListener(userId, sessionId, extension);
6665
}
67-
6866
break;
67+
6968
case SignalingConstants.SignalingType.PARAMETERS_CHANGED:
7069
if (typeof self.delegate._onUpdateListener === 'function'){
7170
self.delegate._onUpdateListener(userId, sessionId, extension);
7271
}
73-
7472
break;
7573
}
7674

77-
// we must return true to keep the handler alive
78-
// returning false would remove it after it finishes
75+
/**
76+
* we must return true to keep the handler alive
77+
* returning false would remove it after it finishes
78+
*/
7979
return true;
8080
};
8181

@@ -90,27 +90,28 @@ function WebRTCSignalingProcessor(service, delegate, connection) {
9090
for (var i = 0, len = extraParams.childNodes.length; i < len; i++) {
9191
if (extraParams.childNodes[i].tagName === 'iceCandidates') {
9292

93-
// iceCandidates
93+
/** iceCandidates */
9494
items = extraParams.childNodes[i].childNodes;
9595

9696
for (var j = 0, len2 = items.length; j < len2; j++) {
9797
candidate = {};
9898
childrenNodes = items[j].childNodes;
99+
99100
for (var k = 0, len3 = childrenNodes.length; k < len3; k++) {
100101
candidate[childrenNodes[k].tagName] = childrenNodes[k].textContent;
101102
}
103+
102104
iceCandidates.push(candidate);
103105
}
104106

105107
} else if (extraParams.childNodes[i].tagName === 'opponentsIDs') {
106-
107-
// opponentsIDs
108+
/** opponentsIDs */
108109
items = extraParams.childNodes[i].childNodes;
109-
for (var j = 0, len2 = items.length; j < len2; j++) {
110-
opponent = items[j].textContent;
110+
111+
for (var v = 0, len2v = items.length; v < len2v; v++) {
112+
opponent = items[v].textContent;
111113
opponents.push(parseInt(opponent));
112114
}
113-
114115
} else {
115116
if (extraParams.childNodes[i].childNodes.length > 1) {
116117
var nodeTextContentSize = extraParams.childNodes[i].textContent.length;
@@ -126,9 +127,7 @@ function WebRTCSignalingProcessor(service, delegate, connection) {
126127
extension = self._XMLtoJS(extension, extraParams.childNodes[i].tagName, extraParams.childNodes[i]);
127128
}
128129
} else {
129-
130130
extension[extraParams.childNodes[i].tagName] = extraParams.childNodes[i].textContent;
131-
132131
}
133132
}
134133
}
@@ -139,14 +138,14 @@ function WebRTCSignalingProcessor(service, delegate, connection) {
139138
extension.opponentsIDs = opponents;
140139
}
141140

142-
143141
return extension;
144142
};
145143

146144
// TODO: the magic
147145
this._XMLtoJS = function(extension, title, obj) {
148146
var self = this;
149147
extension[title] = {};
148+
150149
for (var i = 0, len = obj.childNodes.length; i < len; i++) {
151150
if (obj.childNodes[i].childNodes.length > 1) {
152151
extension[title] = self._XMLtoJS(extension[title], obj.childNodes[i].tagName, obj.childNodes[i]);
@@ -158,4 +157,4 @@ function WebRTCSignalingProcessor(service, delegate, connection) {
158157
};
159158
}
160159

161-
module.exports = WebRTCSignalingProcessor;
160+
module.exports = WebRTCSignalingProcessor;

‎js/modules/webrtc/qbWebRTCSignalingProvider.js

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
1-
/*
1+
/**
22
* QuickBlox JavaScript SDK
3-
*
43
* WebRTC Module (WebRTC signaling processor)
5-
*
64
*/
75

86
require('../../../lib/strophe/strophe.min');
7+
98
var Helpers = require('./qbWebRTCHelpers');
109
var SignalingConstants = require('./qbWebRTCSignalingConstants');
1110
var Utils = require('../../qbUtils');
@@ -16,28 +15,27 @@ function WebRTCSignalingProvider(service, connection) {
1615
this.connection = connection;
1716
}
1817

19-
WebRTCSignalingProvider.prototype.sendCandidate = function(userId, iceCandidates, extension) {
20-
var extension = extension || {};
18+
WebRTCSignalingProvider.prototype.sendCandidate = function(userId, iceCandidates, ext) {
19+
var extension = ext || {};
2120
extension["iceCandidates"] = iceCandidates;
2221

2322
this.sendMessage(userId, extension, SignalingConstants.SignalingType.CANDIDATE);
2423
};
2524

26-
WebRTCSignalingProvider.prototype.sendMessage = function(userId, extension, signalingType) {
27-
var extension = extension || {},
25+
WebRTCSignalingProvider.prototype.sendMessage = function(userId, ext, signalingType) {
26+
var extension = ext || {},
2827
self = this,
2928
msg, params;
3029

31-
// basic parameters
32-
//
30+
/** basic parameters */
3331
extension.moduleIdentifier = SignalingConstants.MODULE_ID;
3432
extension.signalType = signalingType;
35-
// extension.sessionID
36-
// extension.callType
33+
/** extension.sessionID */
34+
/** extension.callType */
3735
extension.platform = 'web';
38-
// extension.callerID
39-
// extension.opponentsIDs
40-
// extension.sdp
36+
/** extension.callerID */
37+
/** extension.opponentsIDs */
38+
/** extension.sdp */
4139

4240
params = {
4341
to: Helpers.getUserJid(userId, config.creds.appId),
@@ -52,7 +50,7 @@ WebRTCSignalingProvider.prototype.sendMessage = function(userId, extension, sign
5250
Object.keys(extension).forEach(function(field) {
5351
if (field === 'iceCandidates') {
5452

55-
// iceCandidates
53+
/** iceCandidates */
5654
msg = msg.c('iceCandidates');
5755
extension[field].forEach(function(candidate) {
5856
msg = msg.c('iceCandidate');
@@ -64,16 +62,14 @@ WebRTCSignalingProvider.prototype.sendMessage = function(userId, extension, sign
6462
msg.up();
6563

6664
} else if (field === 'opponentsIDs') {
67-
68-
// opponentsIDs
65+
/** opponentsIDs */
6966
msg = msg.c('opponentsIDs');
7067
extension[field].forEach(function(opponentId) {
7168
msg = msg.c('opponentID').t(opponentId).up();
7269
});
7370
msg.up();
7471

7572
} else if (typeof extension[field] === 'object') {
76-
7773
self._JStoXML(field, extension[field], msg);
7874

7975
} else {
@@ -84,7 +80,7 @@ WebRTCSignalingProvider.prototype.sendMessage = function(userId, extension, sign
8480
this.connection.send(msg);
8581
};
8682

87-
// TODO: the magic
83+
/** TODO: the magic */
8884
WebRTCSignalingProvider.prototype._JStoXML = function(title, obj, msg) {
8985
var self = this;
9086
msg.c(title);
@@ -97,4 +93,4 @@ WebRTCSignalingProvider.prototype._JStoXML = function(title, obj, msg) {
9793
msg.up();
9894
};
9995

100-
module.exports = WebRTCSignalingProvider;
96+
module.exports = WebRTCSignalingProvider;

‎quickblox.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)