Skip to content

Commit 31ba2a8

Browse files
author
Igor Khomenko
committed
added an abiulity to init SDK via QB.init(56655ac9a0eb476d92002b66, CREDENTIALS.appId)
1 parent b79b858 commit 31ba2a8

File tree

6 files changed

+49
-87
lines changed

6 files changed

+49
-87
lines changed

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "quickblox",
33
"description": "QuickBlox JavaScript SDK",
4-
"version": "1.17.0",
4+
"version": "1.17.1",
55
"homepage": "http://quickblox.com/developers/Javascript",
66
"main": "quickblox.js",
77
"license": "BSD",

js/qbConfig.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
*/
77

88
var config = {
9-
version: '1.17.0',
9+
version: '1.17.1',
1010
creds: {
1111
appId: '',
1212
authKey: '',

js/qbMain.js

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ function QuickBlox() {}
1515

1616
QuickBlox.prototype = {
1717

18-
init: function(appId, authKey, authSecret, configMap) {
18+
init: function(appIdOrToken, authKeyOrAppId, authSecret, configMap) {
1919
if (configMap && typeof configMap === 'object') {
2020
config.set(configMap);
2121
}
@@ -51,11 +51,16 @@ QuickBlox.prototype = {
5151
this.data = new Data(this.service);
5252

5353
// Initialization by outside token
54-
if (typeof appId === 'string' && !authKey && !authSecret) {
55-
this.service.setSession({ token: appId });
54+
if (typeof appIdOrToken === 'string' && (!authKeyOrAppId || typeof authKeyOrAppId === 'number') && !authSecret) {
55+
56+
if(typeof authKeyOrAppId === 'number'){
57+
config.creds.appId = authKeyOrAppId;
58+
}
59+
60+
this.service.setSession({ token: appIdOrToken });
5661
} else {
57-
config.creds.appId = appId;
58-
config.creds.authKey = authKey;
62+
config.creds.appId = appIdOrToken;
63+
config.creds.authKey = authKeyOrAppId;
5964
config.creds.authSecret = authSecret;
6065
}
6166
},

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "quickblox",
33
"description": "QuickBlox JavaScript SDK",
4-
"version": "1.17.0",
4+
"version": "1.17.1",
55
"homepage": "http://quickblox.com/developers/Javascript",
66
"main": "js/qbMain.js",
77
"license": [

quickblox.min.js

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/QB-CoreSpec.js

Lines changed: 28 additions & 71 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,17 @@ var REST_REQUESTS_TIMEOUT = 3000;
33
describe('Session API', function() {
44

55

6-
// Load config
6+
// can Init (simple)
77
//
8-
beforeAll(function (){
8+
it('can init SDK with session token and appId', function(){
9+
QB.init("56655ac9a0eb476d92002b66", CREDENTIALS.appId);
10+
11+
expect(QB.service.qbInst.config.creds.appId).toEqual(CREDENTIALS.appId);
12+
});
13+
14+
// can Init
15+
//
16+
it('can init SDK with appId, authKey, authSecret, config', function(){
917
QB.init(CREDENTIALS.appId, CREDENTIALS.authKey, CREDENTIALS.authSecret, CONFIG);
1018

1119
expect(QB.service.qbInst.config.creds.appId).toEqual(CREDENTIALS.appId);
@@ -47,96 +55,45 @@ describe('Session API', function() {
4755
}, REST_REQUESTS_TIMEOUT);
4856

4957

50-
// Destroy a session
51-
//
52-
it('can destroy a session', function(done){
53-
54-
QB.createSession(function (err, result){
55-
if(err){
56-
done.fail("Destroy session error1: " + JSON.stringify(err));
57-
}else{
58-
QB.destroySession(function (err, result){
59-
if(err){
60-
done.fail("Destroy session error2: " + JSON.stringify(err));
61-
}else{
62-
expect(QB.service.qbInst.session).toBeNull();
63-
done()
64-
}
65-
});
66-
}
67-
});
68-
}, REST_REQUESTS_TIMEOUT);
69-
70-
7158
// Login a user
7259
//
7360
it('can login a user', function(done){
74-
75-
QB.createSession(function (err, result){
61+
QB.login(QBUser1, function (err, user){
7662
if(err){
77-
done.fail("Login user error1: " + JSON.stringify(err));
63+
done.fail("Login user error2: " + JSON.stringify(err));
7864
}else{
79-
QB.login(QBUser1, function (err, user){
80-
if(err){
81-
done.fail("Login user error2: " + JSON.stringify(err));
82-
}else{
83-
expect(user).not.toBeNull();
84-
expect(user.login).toEqual(QBUser1.login);
85-
expect(user.id).toEqual(QBUser1.id);
86-
done()
87-
}
88-
});
65+
expect(user).not.toBeNull();
66+
expect(user.login).toEqual(QBUser1.login);
67+
expect(user.id).toEqual(QBUser1.id);
68+
done()
8969
}
9070
});
9171
}, REST_REQUESTS_TIMEOUT);
9272

9373

94-
// Login a user when initialised with just a valid token
74+
// Logout a user
9575
//
96-
it('can login a user when initialised with just a valid token', function(done){
97-
98-
QB.createSession(function (err, session){
76+
it('can logout a user', function(done){
77+
QB.logout(function(err, result){
9978
if(err){
100-
done.fail("Login user when initialised with just a valid token error1: " + JSON.stringify(err));
79+
done.fail("Logout user error3: " + JSON.stringify(err));
10180
}else{
102-
QB.init(session.token);
103-
104-
QB.login(QBUser1, function (err, user){
105-
if(err){
106-
done.fail("Login user when initialised with just a valid token error2: " + JSON.stringify(err));
107-
}else{
108-
expect(user).not.toBeNull();
109-
expect(user.login).toEqual(QBUser1.login);
110-
expect(user.id).toEqual(QBUser1.id);
111-
done();
112-
}
113-
});
81+
expect(null).toBeNull(); // we just have to have some expectations.
82+
done();
11483
}
11584
});
11685
}, REST_REQUESTS_TIMEOUT);
11786

11887

119-
// Logout a user
88+
// Destroy a session
12089
//
121-
it('can logout a user', function(done){
122-
123-
QB.createSession(function (err, result){
90+
it('can destroy a session', function(done){
91+
QB.destroySession(function (err, result){
12492
if(err){
125-
done.fail("Logout user error1: " + JSON.stringify(err));
93+
done.fail("Destroy session error2: " + JSON.stringify(err));
12694
}else{
127-
QB.login(QBUser1, function (err, user){
128-
if(err){
129-
done.fail("Logout user error2: " + JSON.stringify(err));
130-
}else{
131-
QB.logout(function(err, result){
132-
if(err){
133-
done.fail("Logout user error3: " + JSON.stringify(err));
134-
}else{
135-
done();
136-
}
137-
});
138-
}
139-
});
95+
expect(QB.service.qbInst.session).toBeNull();
96+
done()
14097
}
14198
});
14299
}, REST_REQUESTS_TIMEOUT);

0 commit comments

Comments
 (0)