Skip to content

Commit 371ea32

Browse files
committed
breaks flang build: Revert [Flang-RT] Environment introspection for quadmath.h (llvm#130411)
1 parent 050d1cb commit 371ea32

File tree

7 files changed

+9
-56
lines changed

7 files changed

+9
-56
lines changed

flang-rt/CMakeLists.txt

Lines changed: 1 addition & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -256,46 +256,6 @@ set(HAVE_BACKTRACE ${Backtrace_FOUND})
256256
set(BACKTRACE_HEADER ${Backtrace_HEADER})
257257

258258

259-
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
260-
if (NOT DEFINED FLANG_RT_GCC_RESOURCE_DIR)
261-
set(FLANG_RT_GCC_RESOURCE_DIR "FLANG_RT_GCC_RESOURCE_DIR-NOTFOUND")
262-
execute_process(
263-
COMMAND "${CMAKE_CXX_COMPILER}" -v -c "${FLANG_RT_SOURCE_DIR}/cmake/clang_gcc_root.cpp" ${CMAKE_CXX_FLAGS} -###
264-
ERROR_FILE "${CMAKE_CURRENT_BINARY_DIR}/clang_gcc_root_result"
265-
)
266-
file(STRINGS "${CMAKE_CURRENT_BINARY_DIR}/clang_gcc_root_result" _errorresult)
267-
foreach (_line IN LISTS _errorresult)
268-
string(REGEX MATCH
269-
"^Selected GCC installation: (.+)$"
270-
_match
271-
"${_line}")
272-
if (CMAKE_MATCH_1)
273-
set(FLANG_RT_GCC_RESOURCE_DIR "${CMAKE_MATCH_1}")
274-
message(STATUS "Found GCC installation selected by Clang: ${FLANG_RT_GCC_RESOURCE_DIR}")
275-
break()
276-
endif ()
277-
endforeach ()
278-
set(FLANG_RT_GCC_RESOURCE_DIR "${FLANG_RT_GCC_RESOURCE_DIR}" CACHE INTERNAL "Path to GCC's resource dir selected by Clang" FORCE)
279-
endif ()
280-
endif ()
281-
282-
check_include_file("quadmath.h" FOUND_QUADMATH_H)
283-
if (FOUND_QUADMATH_H)
284-
message(STATUS "quadmath.h found without additional include paths")
285-
set(FLANG_RT_INCLUDE_QUADMATH_H "<quadmath.h>")
286-
elseif (FLANG_RT_GCC_RESOURCE_DIR)
287-
cmake_push_check_state()
288-
list(APPEND CMAKE_REQUIRED_INCLUDES "${FLANG_RT_GCC_RESOURCE_DIR}/include")
289-
check_include_file("quadmath.h" FOUND_GCC_QUADMATH_H)
290-
cmake_pop_check_state()
291-
if (FOUND_GCC_QUADMATH_H)
292-
message(STATUS "quadmath.h found in Clang's selected GCC installation")
293-
set(FLANG_RT_INCLUDE_QUADMATH_H "\"${FLANG_RT_GCC_RESOURCE_DIR}/include/quadmath.h\"")
294-
endif ()
295-
endif ()
296-
297-
298-
299259
#####################
300260
# Build Preparation #
301261
#####################
@@ -317,9 +277,7 @@ set(CMAKE_CXX_STANDARD_REQUIRED YES)
317277

318278

319279
configure_file(cmake/config.h.cmake.in config.h)
320-
if (FLANG_RT_INCLUDE_QUADMATH_H)
321-
configure_file("cmake/quadmath_wrapper.h.in" "${FLANG_RT_BINARY_DIR}/quadmath_wrapper.h")
322-
endif ()
280+
323281

324282
# The bootstrap build will create a phony target with the same as the top-level
325283
# directory ("flang-rt") and delegate it to the runtimes build dir.

flang-rt/cmake/clang_gcc_root.cpp

Lines changed: 0 additions & 1 deletion
This file was deleted.

flang-rt/cmake/quadmath_wrapper.h.in

Lines changed: 0 additions & 9 deletions
This file was deleted.

flang-rt/lib/quadmath/CMakeLists.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,8 @@ target_include_directories(FortranFloat128MathILib INTERFACE
7878

7979
if (FLANG_RUNTIME_F128_MATH_LIB)
8080
if (${FLANG_RUNTIME_F128_MATH_LIB} STREQUAL "libquadmath")
81-
if(FLANG_RT_INCLUDE_QUADMATH_H)
81+
check_include_file(quadmath.h FOUND_QUADMATH_HEADER)
82+
if(FOUND_QUADMATH_HEADER)
8283
add_compile_definitions(HAS_QUADMATHLIB)
8384
else()
8485
message(FATAL_ERROR

flang-rt/lib/quadmath/complex-math.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#include "flang/Runtime/entry-names.h"
1414

1515
#if HAS_QUADMATHLIB
16-
#include "quadmath_wrapper.h"
16+
#include "quadmath.h"
1717
#define CAbs(x) cabsq(x)
1818
#define CAcos(x) cacosq(x)
1919
#define CAcosh(x) cacoshq(x)

flang-rt/lib/quadmath/math-entries.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ DEFINE_FALLBACK_F128(Yn)
112112

113113
#if HAS_QUADMATHLIB
114114
// Define wrapper callers for libquadmath.
115-
#include "quadmath_wrapper.h"
115+
#include "quadmath.h"
116116
DEFINE_SIMPLE_ALIAS(Abs, fabsq)
117117
DEFINE_SIMPLE_ALIAS(Acos, acosq)
118118
DEFINE_SIMPLE_ALIAS(Acosh, acoshq)

revert_patches.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,7 @@ revert: breaks build of rccl __cpuidex
2020
1c28b92373 [Clang] __has_builtin should return false for aux triple builtins (#121839)
2121
Ron and Saiyed
2222
---
23+
breaks flang build quadmath_wrapper.h
24+
[Flang-RT] Environment introspection for quadmath.h (#130411)
25+
Kruse, palermo
26+
--

0 commit comments

Comments
 (0)