Skip to content

Commit aa52d41

Browse files
pravinjagtapSyamaAmd
authored andcommitted
[AMDGPU][NFC] Precommit tests representing agpr spills. (llvm#115270)
Presently we are only marking implicit-def for the spilled AGPR tuple in the first spill instructions and not implicit. Change-Id: I1667df1d89a54346dc55662f2c7f89d335376b77
1 parent f871baa commit aa52d41

File tree

1 file changed

+150
-0
lines changed

1 file changed

+150
-0
lines changed
Lines changed: 150 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,150 @@
1+
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
2+
# RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx908 %s -o - -run-pass prologepilog -verify-machineinstrs | FileCheck -check-prefix=GFX908-PEI %s
3+
# RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx908 %s -o - -run-pass prologepilog,machine-cp -verify-machineinstrs | FileCheck -check-prefix=GFX908-PEI-MACHINECP %s
4+
5+
# When VGPRs are available for spilling, prologepilog marks the tuple implicit-def as well as implicit in the first spill instruction.
6+
# As a consequence, machine-cp would NOT delete agpr2 copy here.
7+
8+
---
9+
name: agpr-spill-to-vgpr-machine-cp
10+
tracksRegLiveness: true
11+
stack:
12+
- { id: 0, name: '', type: spill-slot, offset: 0, size: 128, alignment: 4 }
13+
machineFunctionInfo:
14+
scratchRSrcReg: $sgpr0_sgpr1_sgpr2_sgpr3
15+
stackPtrOffsetReg: '$sgpr32'
16+
hasSpilledVGPRs: true
17+
body: |
18+
bb.0:
19+
successors:
20+
liveins: $vgpr0, $vgpr1
21+
; GFX908-PEI-LABEL: name: agpr-spill-to-vgpr-machine-cp
22+
; GFX908-PEI: liveins: $vgpr0, $vgpr1, $vgpr2, $vgpr3, $vgpr4, $vgpr5, $vgpr6, $vgpr7, $vgpr8, $vgpr9, $vgpr10, $vgpr11, $vgpr12, $vgpr13, $vgpr14, $vgpr15, $vgpr16, $vgpr17, $vgpr18, $vgpr19, $vgpr20, $vgpr21, $vgpr22, $vgpr23, $vgpr24, $vgpr25, $vgpr26, $vgpr27, $vgpr28, $vgpr29, $vgpr30, $vgpr31, $vgpr32, $vgpr33
23+
; GFX908-PEI-NEXT: {{ $}}
24+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION llvm_def_aspace_cfa $sgpr32_lo16, 0, 6
25+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION llvm_register_pair $pc_reg, $sgpr30_lo16, 32, $sgpr31_lo16, 32
26+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr31_lo16
27+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr32_lo16
28+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr33_lo16
29+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $agpr0_lo16
30+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $agpr1_lo16
31+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $agpr2_lo16
32+
; GFX908-PEI-NEXT: renamable $agpr0 = COPY renamable $vgpr0, implicit $exec
33+
; GFX908-PEI-NEXT: renamable $agpr2 = COPY renamable $vgpr1, implicit $exec
34+
; GFX908-PEI-NEXT: $vgpr33 = V_ACCVGPR_READ_B32_e64 $agpr0, implicit $exec, implicit-def $agpr0_agpr1_agpr2, implicit $agpr0_agpr1_agpr2
35+
; GFX908-PEI-NEXT: $vgpr32 = V_ACCVGPR_READ_B32_e64 $agpr1, implicit $exec
36+
; GFX908-PEI-NEXT: $vgpr31 = V_ACCVGPR_READ_B32_e64 $agpr2, implicit $exec, implicit $agpr0_agpr1_agpr2
37+
; GFX908-PEI-NEXT: S_ENDPGM 0
38+
;
39+
; GFX908-PEI-MACHINECP-LABEL: name: agpr-spill-to-vgpr-machine-cp
40+
; GFX908-PEI-MACHINECP: liveins: $vgpr0, $vgpr1, $vgpr2, $vgpr3, $vgpr4, $vgpr5, $vgpr6, $vgpr7, $vgpr8, $vgpr9, $vgpr10, $vgpr11, $vgpr12, $vgpr13, $vgpr14, $vgpr15, $vgpr16, $vgpr17, $vgpr18, $vgpr19, $vgpr20, $vgpr21, $vgpr22, $vgpr23, $vgpr24, $vgpr25, $vgpr26, $vgpr27, $vgpr28, $vgpr29, $vgpr30, $vgpr31, $vgpr32, $vgpr33
41+
; GFX908-PEI-MACHINECP-NEXT: {{ $}}
42+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION llvm_def_aspace_cfa $sgpr32_lo16, 0, 6
43+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION llvm_register_pair $pc_reg, $sgpr30_lo16, 32, $sgpr31_lo16, 32
44+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr31_lo16
45+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr32_lo16
46+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr33_lo16
47+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $agpr0_lo16
48+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $agpr1_lo16
49+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $agpr2_lo16
50+
; GFX908-PEI-MACHINECP-NEXT: renamable $agpr0 = COPY renamable $vgpr0, implicit $exec
51+
; GFX908-PEI-MACHINECP-NEXT: renamable $agpr2 = COPY renamable $vgpr1, implicit $exec
52+
; GFX908-PEI-MACHINECP-NEXT: $vgpr33 = V_ACCVGPR_READ_B32_e64 $agpr0, implicit $exec, implicit-def $agpr0_agpr1_agpr2, implicit $agpr0_agpr1_agpr2
53+
; GFX908-PEI-MACHINECP-NEXT: $vgpr32 = V_ACCVGPR_READ_B32_e64 $agpr1, implicit $exec
54+
; GFX908-PEI-MACHINECP-NEXT: $vgpr31 = V_ACCVGPR_READ_B32_e64 $agpr2, implicit $exec, implicit $agpr0_agpr1_agpr2
55+
; GFX908-PEI-MACHINECP-NEXT: S_ENDPGM 0
56+
renamable $agpr0 = COPY renamable $vgpr0, implicit $exec
57+
renamable $agpr2 = COPY renamable $vgpr1, implicit $exec
58+
SI_SPILL_AV96_SAVE $agpr0_agpr1_agpr2, %stack.0, $sgpr32, 0, implicit $exec :: (store (s96) into %stack.0, align 4, addrspace 5)
59+
S_ENDPGM 0
60+
...
61+
62+
# When VGPRs are NOT available for spilling (stack is used), prologepilog marks the tuple implicit-def only and NOT implicit.
63+
# As a consequence, machine-cp would delete agpr2 copy here. Presently, this is incorrect behavior.
64+
65+
---
66+
name: agpr-spill-to-vgpr-to-stack-machine-cp
67+
tracksRegLiveness: true
68+
stack:
69+
- { id: 0, name: '', type: spill-slot, offset: 0, size: 128, alignment: 4 }
70+
machineFunctionInfo:
71+
scratchRSrcReg: $sgpr0_sgpr1_sgpr2_sgpr3
72+
stackPtrOffsetReg: '$sgpr32'
73+
hasSpilledVGPRs: true
74+
body: |
75+
bb.0:
76+
successors:
77+
liveins: $vgpr0, $vgpr1
78+
; GFX908-PEI-LABEL: name: agpr-spill-to-vgpr-to-stack-machine-cp
79+
; GFX908-PEI: liveins: $vgpr0, $vgpr1, $vgpr18, $vgpr19, $vgpr20, $vgpr21, $vgpr22, $vgpr23, $vgpr24, $vgpr25, $vgpr26, $vgpr27, $vgpr28, $vgpr29, $vgpr30, $vgpr31, $vgpr32, $vgpr33, $vgpr34, $vgpr35, $vgpr36, $vgpr37, $vgpr38, $vgpr39, $vgpr48, $vgpr49, $vgpr50, $vgpr51, $vgpr52, $vgpr53, $vgpr54, $vgpr55
80+
; GFX908-PEI-NEXT: {{ $}}
81+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION llvm_def_aspace_cfa $sgpr32_lo16, 0, 6
82+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION llvm_register_pair $pc_reg, $sgpr30_lo16, 32, $sgpr31_lo16, 32
83+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr2_lo16
84+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr3_lo16
85+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr4_lo16
86+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr5_lo16
87+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr6_lo16
88+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr7_lo16
89+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr8_lo16
90+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr9_lo16
91+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr10_lo16
92+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr11_lo16
93+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr12_lo16
94+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr13_lo16
95+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr14_lo16
96+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr15_lo16
97+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr16_lo16
98+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr17_lo16
99+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $agpr0_lo16
100+
; GFX908-PEI-NEXT: frame-setup CFI_INSTRUCTION undefined $agpr2_lo16
101+
; GFX908-PEI-NEXT: renamable $agpr0 = COPY renamable $vgpr0, implicit $exec
102+
; GFX908-PEI-NEXT: renamable $agpr2 = COPY renamable $vgpr1, implicit $exec
103+
; GFX908-PEI-NEXT: $vgpr2_vgpr3_vgpr4_vgpr5_vgpr6_vgpr7_vgpr8_vgpr9 = IMPLICIT_DEF
104+
; GFX908-PEI-NEXT: $vgpr10_vgpr11_vgpr12_vgpr13_vgpr14_vgpr15_vgpr16_vgpr17 = IMPLICIT_DEF
105+
; GFX908-PEI-NEXT: $vgpr40 = V_ACCVGPR_READ_B32_e64 $agpr0, implicit $exec, implicit-def $agpr0_agpr1_agpr2
106+
; GFX908-PEI-NEXT: BUFFER_STORE_DWORD_OFFSET $vgpr40, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 0, 0, 0, implicit $exec, implicit $agpr0_agpr1_agpr2 :: (store (s32) into %stack.0, addrspace 5)
107+
; GFX908-PEI-NEXT: $vgpr40 = V_ACCVGPR_READ_B32_e64 $agpr1, implicit $exec
108+
; GFX908-PEI-NEXT: BUFFER_STORE_DWORD_OFFSET $vgpr40, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 4, 0, 0, implicit $exec :: (store (s32) into %stack.0 + 4, addrspace 5)
109+
; GFX908-PEI-NEXT: $vgpr55 = V_ACCVGPR_READ_B32_e64 $agpr2, implicit $exec, implicit $agpr0_agpr1_agpr2
110+
; GFX908-PEI-NEXT: S_ENDPGM 0
111+
;
112+
; GFX908-PEI-MACHINECP-LABEL: name: agpr-spill-to-vgpr-to-stack-machine-cp
113+
; GFX908-PEI-MACHINECP: liveins: $vgpr0, $vgpr1, $vgpr18, $vgpr19, $vgpr20, $vgpr21, $vgpr22, $vgpr23, $vgpr24, $vgpr25, $vgpr26, $vgpr27, $vgpr28, $vgpr29, $vgpr30, $vgpr31, $vgpr32, $vgpr33, $vgpr34, $vgpr35, $vgpr36, $vgpr37, $vgpr38, $vgpr39, $vgpr48, $vgpr49, $vgpr50, $vgpr51, $vgpr52, $vgpr53, $vgpr54, $vgpr55
114+
; GFX908-PEI-MACHINECP-NEXT: {{ $}}
115+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION llvm_def_aspace_cfa $sgpr32_lo16, 0, 6
116+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION llvm_register_pair $pc_reg, $sgpr30_lo16, 32, $sgpr31_lo16, 32
117+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr2_lo16
118+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr3_lo16
119+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr4_lo16
120+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr5_lo16
121+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr6_lo16
122+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr7_lo16
123+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr8_lo16
124+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr9_lo16
125+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr10_lo16
126+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr11_lo16
127+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr12_lo16
128+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr13_lo16
129+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr14_lo16
130+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr15_lo16
131+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr16_lo16
132+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $vgpr17_lo16
133+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $agpr0_lo16
134+
; GFX908-PEI-MACHINECP-NEXT: frame-setup CFI_INSTRUCTION undefined $agpr2_lo16
135+
; GFX908-PEI-MACHINECP-NEXT: renamable $agpr0 = COPY renamable $vgpr0, implicit $exec
136+
; GFX908-PEI-MACHINECP-NEXT: $vgpr2_vgpr3_vgpr4_vgpr5_vgpr6_vgpr7_vgpr8_vgpr9 = IMPLICIT_DEF
137+
; GFX908-PEI-MACHINECP-NEXT: $vgpr10_vgpr11_vgpr12_vgpr13_vgpr14_vgpr15_vgpr16_vgpr17 = IMPLICIT_DEF
138+
; GFX908-PEI-MACHINECP-NEXT: $vgpr40 = V_ACCVGPR_READ_B32_e64 $agpr0, implicit $exec, implicit-def $agpr0_agpr1_agpr2
139+
; GFX908-PEI-MACHINECP-NEXT: BUFFER_STORE_DWORD_OFFSET $vgpr40, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 0, 0, 0, implicit $exec, implicit $agpr0_agpr1_agpr2 :: (store (s32) into %stack.0, addrspace 5)
140+
; GFX908-PEI-MACHINECP-NEXT: $vgpr40 = V_ACCVGPR_READ_B32_e64 $agpr1, implicit $exec
141+
; GFX908-PEI-MACHINECP-NEXT: BUFFER_STORE_DWORD_OFFSET $vgpr40, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 4, 0, 0, implicit $exec :: (store (s32) into %stack.0 + 4, addrspace 5)
142+
; GFX908-PEI-MACHINECP-NEXT: $vgpr55 = V_ACCVGPR_READ_B32_e64 $agpr2, implicit $exec, implicit $agpr0_agpr1_agpr2
143+
; GFX908-PEI-MACHINECP-NEXT: S_ENDPGM 0
144+
renamable $agpr0 = COPY renamable $vgpr0, implicit $exec
145+
renamable $agpr2 = COPY renamable $vgpr1, implicit $exec
146+
$vgpr2_vgpr3_vgpr4_vgpr5_vgpr6_vgpr7_vgpr8_vgpr9 = IMPLICIT_DEF
147+
$vgpr10_vgpr11_vgpr12_vgpr13_vgpr14_vgpr15_vgpr16_vgpr17 = IMPLICIT_DEF
148+
SI_SPILL_AV96_SAVE $agpr0_agpr1_agpr2, %stack.0, $sgpr32, 0, implicit $exec :: (store (s96) into %stack.0, align 4, addrspace 5)
149+
S_ENDPGM 0
150+
...

0 commit comments

Comments
 (0)