Skip to content

Commit bf5c354

Browse files
committed
Revert "[Flang][Driver][AMDGPU] Fix -mcode-object-version (llvm#134230)"
breaks many smoke-fort, ovo, sollve tests This reverts commit a17d496.
1 parent eb468b8 commit bf5c354

File tree

5 files changed

+1
-44
lines changed

5 files changed

+1
-44
lines changed

clang/lib/Driver/ToolChains/Flang.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -427,9 +427,6 @@ void Flang::AddAMDGPUTargetArgs(const ArgList &Args,
427427
if (Arg *A = Args.getLastArg(options::OPT_mcode_object_version_EQ)) {
428428
StringRef Val = A->getValue();
429429
CmdArgs.push_back(Args.MakeArgString("-mcode-object-version=" + Val));
430-
CmdArgs.push_back(Args.MakeArgString("-mllvm"));
431-
CmdArgs.push_back(
432-
Args.MakeArgString("--amdhsa-code-object-version=" + Val));
433430
}
434431

435432
const ToolChain &TC = getToolChain();

flang/include/flang/Frontend/CodeGenOptions.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ class CodeGenOptions : public CodeGenOptionsBase {
9595

9696
/// \brief Code object version for AMDGPU.
9797
llvm::CodeObjectVersionKind CodeObjectVersion =
98-
llvm::CodeObjectVersionKind::COV_None;
98+
llvm::CodeObjectVersionKind::COV_5;
9999

100100
/// Optimization remark with an optional regular expression pattern.
101101
struct OptRemark {

flang/lib/Frontend/FrontendActions.cpp

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -863,17 +863,6 @@ void CodeGenAction::generateLLVMIR() {
863863
llvmModule->addModuleFlag(
864864
llvm::Module::Error, "target-abi",
865865
llvm::MDString::get(llvmModule->getContext(), targetOpts.abi));
866-
867-
if (triple.isAMDGPU() ||
868-
(triple.isSPIRV() && triple.getVendor() == llvm::Triple::AMD)) {
869-
// Emit amdhsa_code_object_version module flag, which is code object version
870-
// times 100.
871-
if (opts.CodeObjectVersion != llvm::CodeObjectVersionKind::COV_None) {
872-
llvmModule->addModuleFlag(llvm::Module::Error,
873-
"amdhsa_code_object_version",
874-
opts.CodeObjectVersion);
875-
}
876-
}
877866
}
878867

879868
static std::unique_ptr<llvm::raw_pwrite_stream>

flang/test/Driver/code-object-version.f90

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,5 @@
55
! RUN: %flang -target x86_64-unknown-linux-gnu -mcode-object-version=3 -S %s -o \
66
! RUN: /dev/null 2>&1 | FileCheck --check-prefix=UNUSED_PARAM %s
77

8-
! RUN: %flang -target amdgcn-amd-amdhsa -mcpu=gfx908 -mcode-object-version=5 -nogpulib -c %s -### 2>&1 \
9-
! RUN: | FileCheck %s -check-prefix=VALID_USE
10-
118
! INVALID_VERSION: error: invalid integral value '3' in '-mcode-object-version=3'
129
! UNUSED_PARAM: warning: argument unused during compilation: '-mcode-object-version=3' [-Wunused-command-line-argument]
13-
14-
! VALID_USE: "-fc1" "-triple" "amdgcn-amd-amdhsa"
15-
! VALID_USE-SAME: "-mcode-object-version=5"
16-
! VALID_USE-SAME: "-mllvm" "--amdhsa-code-object-version=5"

flang/test/Integration/amdgpu-code-object-version.f90

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)