Skip to content

Commit 5ab8d09

Browse files
rraminenjithunnair-amd
authored andcommitted
[SOW MS3] Centos stream9 PyTorch image support (#1090)
* changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <[email protected]>
1 parent 3b9ded8 commit 5ab8d09

File tree

6 files changed

+193
-21
lines changed

6 files changed

+193
-21
lines changed

.ci/docker/build.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,12 @@ if [[ "$image" == *cuda* && ${OS} == "ubuntu" ]]; then
283283
fi
284284
fi
285285

286+
if [[ "$image" == *centos9* ]]; then
287+
DOCKERFILE_NAME="Dockerfile.centos.stream"
288+
else
289+
DOCKERFILE_NAME="Dockerfile"
290+
fi
291+
286292
# Build image
287293
# TODO: build-arg THRIFT is not turned on for any image, remove it once we confirm
288294
# it's no longer needed.
@@ -321,7 +327,7 @@ docker build \
321327
--build-arg "CONDA_CMAKE=${CONDA_CMAKE}" \
322328
--build-arg "TRITON=${TRITON}" \
323329
--build-arg "ONNX=${ONNX}" \
324-
-f $(dirname ${DOCKERFILE})/Dockerfile \
330+
-f $(dirname ${DOCKERFILE})/${DOCKERFILE_NAME} \
325331
-t "$tmp_tag" \
326332
"$@" \
327333
.
Lines changed: 108 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
1+
ARG CENTOS_VERSION
2+
3+
FROM quay.io/centos/centos:stream${CENTOS_VERSION}
4+
5+
6+
# Set AMD gpu targets to build for
7+
ARG PYTORCH_ROCM_ARCH
8+
ENV PYTORCH_ROCM_ARCH ${PYTORCH_ROCM_ARCH}
9+
10+
# Install required packages to build Caffe2
11+
12+
# Install common dependencies (so that this step can be cached separately)
13+
ARG EC2
14+
ADD ./common/install_base.sh install_base.sh
15+
RUN bash ./install_base.sh && rm install_base.sh
16+
17+
#Install langpack
18+
RUN yum install -y glibc-langpack-en
19+
20+
# Update CentOS git version
21+
RUN yum -y remove git
22+
RUN yum -y remove git-*
23+
RUN yum install -y git
24+
25+
# Install devtoolset
26+
RUN dnf install -y rpmdevtools
27+
ENV BASH_ENV "/etc/profile"
28+
29+
# Install ninja
30+
RUN dnf --enablerepo=crb install -y ninja-build
31+
32+
# (optional) Install non-default glibc version
33+
ARG GLIBC_VERSION
34+
ADD ./common/install_glibc.sh install_glibc.sh
35+
RUN if [ -n "${GLIBC_VERSION}" ]; then bash ./install_glibc.sh; fi
36+
RUN rm install_glibc.sh
37+
38+
# Install user
39+
ADD ./common/install_user.sh install_user.sh
40+
RUN bash ./install_user.sh && rm install_user.sh
41+
42+
# Install conda and other packages (e.g., numpy, pytest)
43+
ENV PATH /opt/conda/bin:$PATH
44+
ARG ANACONDA_PYTHON_VERSION
45+
ARG CONDA_CMAKE
46+
ADD requirements-ci.txt /opt/conda/requirements-ci.txt
47+
ADD ./common/install_conda.sh install_conda.sh
48+
RUN bash ./install_conda.sh && rm install_conda.sh
49+
RUN rm /opt/conda/requirements-ci.txt
50+
51+
# (optional) Install protobuf for ONNX
52+
ARG PROTOBUF
53+
ADD ./common/install_protobuf.sh install_protobuf.sh
54+
RUN if [ -n "${PROTOBUF}" ]; then bash ./install_protobuf.sh; fi
55+
RUN rm install_protobuf.sh
56+
ENV INSTALLED_PROTOBUF ${PROTOBUF}
57+
58+
# (optional) Install database packages like LMDB and LevelDB
59+
ARG DB
60+
ADD ./common/install_db.sh install_db.sh
61+
RUN if [ -n "${DB}" ]; then bash ./install_db.sh; fi
62+
RUN rm install_db.sh
63+
ENV INSTALLED_DB ${DB}
64+
65+
# (optional) Install vision packages like OpenCV and ffmpeg
66+
ARG VISION
67+
ADD ./common/install_vision.sh install_vision.sh
68+
RUN if [ -n "${VISION}" ]; then bash ./install_vision.sh; fi
69+
RUN rm install_vision.sh
70+
ENV INSTALLED_VISION ${VISION}
71+
72+
# Install rocm
73+
ARG ROCM_VERSION
74+
ADD ./common/install_rocm.sh install_rocm.sh
75+
RUN bash ./install_rocm.sh
76+
RUN rm install_rocm.sh
77+
ENV PATH /opt/rocm/bin:$PATH
78+
ENV PATH /opt/rocm/hcc/bin:$PATH
79+
ENV PATH /opt/rocm/hip/bin:$PATH
80+
ENV PATH /opt/rocm/opencl/bin:$PATH
81+
ENV PATH /opt/rocm/llvm/bin:$PATH
82+
ENV MAGMA_HOME /opt/rocm/magma
83+
ENV LANG en_US.utf8
84+
ENV LC_ALL en_US.utf8
85+
86+
# (optional) Install non-default CMake version
87+
ARG CMAKE_VERSION
88+
ADD ./common/install_cmake.sh install_cmake.sh
89+
RUN if [ -n "${CMAKE_VERSION}" ]; then bash ./install_cmake.sh; fi
90+
RUN rm install_cmake.sh
91+
92+
# (optional) Install non-default Ninja version
93+
ARG NINJA_VERSION
94+
ADD ./common/install_ninja.sh install_ninja.sh
95+
RUN if [ -n "${NINJA_VERSION}" ]; then bash ./install_ninja.sh; fi
96+
RUN rm install_ninja.sh
97+
98+
# Install ccache/sccache (do this last, so we get priority in PATH)
99+
ADD ./common/install_cache.sh install_cache.sh
100+
ENV PATH /opt/cache/bin:$PATH
101+
RUN bash ./install_cache.sh && rm install_cache.sh
102+
103+
# Include BUILD_ENVIRONMENT environment variable in image
104+
ARG BUILD_ENVIRONMENT
105+
ENV BUILD_ENVIRONMENT ${BUILD_ENVIRONMENT}
106+
107+
USER jenkins
108+
CMD ["bash"]

.ci/docker/common/install_base.sh

Lines changed: 21 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,14 +99,21 @@ install_ubuntu() {
9999
install_centos() {
100100
# Need EPEL for many packages we depend on.
101101
# See http://fedoraproject.org/wiki/EPEL
102-
yum --enablerepo=extras install -y epel-release
102+
# extras repo is not there for CentOS 9 and epel-release is already part of repo list
103+
if [[ $OS_VERSION == 9 ]]; then
104+
yum install -y epel-release
105+
ALLOW_ERASE="--allowerasing"
106+
else
107+
yum --enablerepo=extras install -y epel-release
108+
ALLOW_ERASE=""
109+
fi
103110

104111
ccache_deps="asciidoc docbook-dtds docbook-style-xsl libxslt"
105112
numpy_deps="gcc-gfortran"
106113
# Note: protobuf-c-{compiler,devel} on CentOS are too old to be used
107114
# for Caffe2. That said, we still install them to make sure the build
108115
# system opts to build/use protoc and libprotobuf from third-party.
109-
yum install -y \
116+
yum install -y $ALLOW_ERASE \
110117
$ccache_deps \
111118
$numpy_deps \
112119
autoconf \
@@ -124,24 +131,33 @@ install_centos() {
124131
glog-devel \
125132
hiredis-devel \
126133
libstdc++-devel \
127-
libsndfile-devel \
128134
make \
129-
opencv-devel \
130135
sudo \
131136
wget \
132137
vim \
133138
unzip \
134139
gdb
135140

141+
if [[ $OS_VERSION == 9 ]]
142+
then
143+
dnf --enablerepo=crb -y install libsndfile-devel
144+
else
145+
yum install -y \
146+
opencv-devel \
147+
libsndfile-devel
148+
fi
149+
136150
# Cleanup
137151
yum clean all
138152
rm -rf /var/cache/yum
139153
rm -rf /var/lib/yum/yumdb
140154
rm -rf /var/lib/yum/history
141155
}
142156

143-
# Install base packages depending on the base OS
144157
ID=$(grep -oP '(?<=^ID=).+' /etc/os-release | tr -d '"')
158+
OS_VERSION=$(grep -oP '(?<=^VERSION_ID=).+' /etc/os-release | tr -d '"')
159+
160+
# Install base packages depending on the base OS
145161
case "$ID" in
146162
ubuntu)
147163
install_ubuntu

.ci/docker/common/install_db.sh

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,23 @@ install_ubuntu() {
1818
install_centos() {
1919
# Need EPEL for many packages we depend on.
2020
# See http://fedoraproject.org/wiki/EPEL
21-
yum --enablerepo=extras install -y epel-release
21+
if [[ $OS_VERSION == 9 ]]; then
22+
yum install -y epel-release
23+
else
24+
yum --enablerepo=extras install -y epel-release
25+
fi
2226

2327
yum install -y \
2428
hiredis-devel \
25-
leveldb-devel \
26-
lmdb-devel \
27-
snappy-devel
29+
leveldb-devel
30+
31+
if [[ $OS_VERSION == 9 ]]; then
32+
dnf --enablerepo=crb -y install lmdb-devel snappy-devel
33+
else
34+
yum install -y \
35+
lmdb-devel \
36+
snappy-devel
37+
fi
2838

2939
# Cleanup
3040
yum clean all
@@ -33,6 +43,8 @@ install_centos() {
3343
rm -rf /var/lib/yum/history
3444
}
3545

46+
OS_VERSION=$(grep -oP '(?<=^VERSION_ID=).+' /etc/os-release | tr -d '"')
47+
3648
# Install base packages depending on the base OS
3749
ID=$(grep -oP '(?<=^ID=).+' /etc/os-release | tr -d '"')
3850
case "$ID" in

.ci/docker/common/install_rocm.sh

Lines changed: 31 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,16 @@ install_centos() {
8080
yum update -y
8181
yum install -y kmod
8282
yum install -y wget
83-
yum install -y openblas-devel
83+
84+
if [[ $OS_VERSION == 9 ]]; then
85+
dnf install -y openblas-serial
86+
dnf install -y dkms kernel-headers kernel-devel
87+
else
88+
yum install -y openblas-devel
89+
yum install -y dkms kernel-headers-`uname -r` kernel-devel-`uname -r`
90+
fi
8491

8592
yum install -y epel-release
86-
yum install -y dkms kernel-headers-`uname -r` kernel-devel-`uname -r`
8793

8894
if [[ $(ver $ROCM_VERSION) -ge $(ver 4.5) ]]; then
8995
# Add amdgpu repository
@@ -105,23 +111,40 @@ install_centos() {
105111
echo "gpgkey=http://repo.radeon.com/rocm/rocm.gpg.key" >> /etc/yum.repos.d/amdgpu.repo
106112
fi
107113

108-
local rocm_baseurl="http://repo.radeon.com/rocm/yum/${ROCM_VERSION}"
114+
if [[ $OS_VERSION == 9 ]]; then
115+
local rocm_baseurl="invalid-url"
116+
else
117+
local rocm_baseurl="http://repo.radeon.com/rocm/yum/${ROCM_VERSION}/main"
118+
fi
109119
echo "[ROCm]" > /etc/yum.repos.d/rocm.repo
110120
echo "name=ROCm" >> /etc/yum.repos.d/rocm.repo
111121
echo "baseurl=${rocm_baseurl}" >> /etc/yum.repos.d/rocm.repo
112122
echo "enabled=1" >> /etc/yum.repos.d/rocm.repo
113123
echo "gpgcheck=1" >> /etc/yum.repos.d/rocm.repo
114124
echo "gpgkey=http://repo.radeon.com/rocm/rocm.gpg.key" >> /etc/yum.repos.d/rocm.repo
115125

116-
yum update -y
117-
118-
yum install -y \
126+
if [[ $OS_VERSION == 9 ]]; then
127+
yum update -y --nogpgcheck
128+
dnf --enablerepo=crb install -y perl-File-BaseDir
129+
yum install -y --nogpgcheck rocm-ml-sdk rocm-developer-tools
130+
else
131+
yum update -y
132+
yum install -y \
119133
rocm-dev \
120134
rocm-utils \
121135
rocm-libs \
122136
rccl \
123137
rocprofiler-dev \
124138
roctracer-dev
139+
fi
140+
141+
# if search fails it will abort this script; use true to avoid case where search fails
142+
MIOPENKERNELS=$(yum -q search miopenkernels | grep miopenkernels- | awk '{print $1}'| grep -F kdb. || true)
143+
if [[ "x${MIOPENKERNELS}" = x ]]; then
144+
echo "miopenkernels package not available"
145+
else
146+
yum install -y ${MIOPENKERNELS}
147+
fi
125148

126149
# Cleanup
127150
yum clean all
@@ -130,6 +153,8 @@ install_centos() {
130153
rm -rf /var/lib/yum/history
131154
}
132155

156+
OS_VERSION=$(grep -oP '(?<=^VERSION_ID=).+' /etc/os-release | tr -d '"')
157+
133158
# Install Python packages depending on the base OS
134159
ID=$(grep -oP '(?<=^ID=).+' /etc/os-release | tr -d '"')
135160
case "$ID" in

.ci/docker/common/install_vision.sh

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,14 @@ install_ubuntu() {
1616
install_centos() {
1717
# Need EPEL for many packages we depend on.
1818
# See http://fedoraproject.org/wiki/EPEL
19-
yum --enablerepo=extras install -y epel-release
20-
21-
yum install -y \
22-
opencv-devel \
23-
ffmpeg-devel
19+
if [[ $OS_VERSION == 9 ]]; then
20+
yum install -y epel-release
21+
else
22+
yum --enablerepo=extras install -y epel-release
23+
yum install -y \
24+
opencv-devel \
25+
ffmpeg-devel
26+
fi
2427

2528
# Cleanup
2629
yum clean all
@@ -29,6 +32,8 @@ install_centos() {
2932
rm -rf /var/lib/yum/history
3033
}
3134

35+
OS_VERSION=$(grep -oP '(?<=^VERSION_ID=).+' /etc/os-release | tr -d '"')
36+
3237
# Install base packages depending on the base OS
3338
ID=$(grep -oP '(?<=^ID=).+' /etc/os-release | tr -d '"')
3439
case "$ID" in

0 commit comments

Comments
 (0)