Skip to content

Commit 9528ea7

Browse files
rraminenjithunnair-amd
authored andcommitted
[SOW MS3] Centos stream9 PyTorch image support (#1090)
* changes to build Centos stream 9 images * Added scripts for centos and centos stream images * Added an extra line * Add ninja installation * Optimized code * Fixes * Add comment * Optimized code * Added AMDGPU mapping for ROCm 5.2 and invalid-url for rocm_baseurl Co-authored-by: Jithun Nair <[email protected]>
1 parent efd3dad commit 9528ea7

File tree

6 files changed

+197
-23
lines changed

6 files changed

+197
-23
lines changed

.circleci/docker/build.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,12 @@ if [[ "$image" == *cuda* && ${OS} == "ubuntu" ]]; then
299299
fi
300300
fi
301301

302+
if [[ "$image" == *centos9* ]]; then
303+
DOCKERFILE_NAME="Dockerfile.centos.stream"
304+
else
305+
DOCKERFILE_NAME="Dockerfile"
306+
fi
307+
302308
# Build image
303309
# TODO: build-arg THRIFT is not turned on for any image, remove it once we confirm
304310
# it's no longer needed.
@@ -337,7 +343,7 @@ docker build \
337343
--build-arg "ROCM_VERSION=${ROCM_VERSION:-}" \
338344
--build-arg "PYTORCH_ROCM_ARCH=${PYTORCH_ROCM_ARCH:-gfx900;gfx906}" \
339345
--build-arg "IMAGE_NAME=${IMAGE_NAME}" \
340-
-f $(dirname ${DOCKERFILE})/Dockerfile \
346+
-f $(dirname ${DOCKERFILE})/${DOCKERFILE_NAME} \
341347
-t "$tmp_tag" \
342348
"$@" \
343349
.
Lines changed: 107 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,107 @@
1+
ARG CENTOS_VERSION
2+
3+
FROM quay.io/centos/centos:stream${CENTOS_VERSION}
4+
5+
6+
# Set AMD gpu targets to build for
7+
ARG PYTORCH_ROCM_ARCH
8+
ENV PYTORCH_ROCM_ARCH ${PYTORCH_ROCM_ARCH}
9+
10+
# Install required packages to build Caffe2
11+
12+
# Install common dependencies (so that this step can be cached separately)
13+
ARG EC2
14+
ADD ./common/install_base.sh install_base.sh
15+
RUN bash ./install_base.sh && rm install_base.sh
16+
17+
#Install langpack
18+
RUN yum install -y glibc-langpack-en
19+
20+
# Update CentOS git version
21+
RUN yum -y remove git
22+
RUN yum -y remove git-*
23+
RUN yum install -y git
24+
25+
# Install devtoolset
26+
RUN dnf install -y rpmdevtools
27+
ENV BASH_ENV "/etc/profile"
28+
29+
# Install ninja
30+
RUN dnf --enablerepo=crb install -y ninja-build
31+
32+
# (optional) Install non-default glibc version
33+
ARG GLIBC_VERSION
34+
ADD ./common/install_glibc.sh install_glibc.sh
35+
RUN if [ -n "${GLIBC_VERSION}" ]; then bash ./install_glibc.sh; fi
36+
RUN rm install_glibc.sh
37+
38+
# Install user
39+
ADD ./common/install_user.sh install_user.sh
40+
RUN bash ./install_user.sh && rm install_user.sh
41+
42+
# Install conda and other packages (e.g., numpy, pytest)
43+
ENV PATH /opt/conda/bin:$PATH
44+
ARG ANACONDA_PYTHON_VERSION
45+
ADD requirements-ci.txt /opt/conda/requirements-ci.txt
46+
ADD ./common/install_conda.sh install_conda.sh
47+
RUN bash ./install_conda.sh && rm install_conda.sh
48+
RUN rm /opt/conda/requirements-ci.txt
49+
50+
# (optional) Install protobuf for ONNX
51+
ARG PROTOBUF
52+
ADD ./common/install_protobuf.sh install_protobuf.sh
53+
RUN if [ -n "${PROTOBUF}" ]; then bash ./install_protobuf.sh; fi
54+
RUN rm install_protobuf.sh
55+
ENV INSTALLED_PROTOBUF ${PROTOBUF}
56+
57+
# (optional) Install database packages like LMDB and LevelDB
58+
ARG DB
59+
ADD ./common/install_db.sh install_db.sh
60+
RUN if [ -n "${DB}" ]; then bash ./install_db.sh; fi
61+
RUN rm install_db.sh
62+
ENV INSTALLED_DB ${DB}
63+
64+
# (optional) Install vision packages like OpenCV and ffmpeg
65+
ARG VISION
66+
ADD ./common/install_vision.sh install_vision.sh
67+
RUN if [ -n "${VISION}" ]; then bash ./install_vision.sh; fi
68+
RUN rm install_vision.sh
69+
ENV INSTALLED_VISION ${VISION}
70+
71+
# Install rocm
72+
ARG ROCM_VERSION
73+
ADD ./common/install_rocm.sh install_rocm.sh
74+
RUN bash ./install_rocm.sh
75+
RUN rm install_rocm.sh
76+
ENV PATH /opt/rocm/bin:$PATH
77+
ENV PATH /opt/rocm/hcc/bin:$PATH
78+
ENV PATH /opt/rocm/hip/bin:$PATH
79+
ENV PATH /opt/rocm/opencl/bin:$PATH
80+
ENV PATH /opt/rocm/llvm/bin:$PATH
81+
ENV MAGMA_HOME /opt/rocm/magma
82+
ENV LANG en_US.utf8
83+
ENV LC_ALL en_US.utf8
84+
85+
# (optional) Install non-default CMake version
86+
ARG CMAKE_VERSION
87+
ADD ./common/install_cmake.sh install_cmake.sh
88+
RUN if [ -n "${CMAKE_VERSION}" ]; then bash ./install_cmake.sh; fi
89+
RUN rm install_cmake.sh
90+
91+
# (optional) Install non-default Ninja version
92+
ARG NINJA_VERSION
93+
ADD ./common/install_ninja.sh install_ninja.sh
94+
RUN if [ -n "${NINJA_VERSION}" ]; then bash ./install_ninja.sh; fi
95+
RUN rm install_ninja.sh
96+
97+
# Install ccache/sccache (do this last, so we get priority in PATH)
98+
ADD ./common/install_cache.sh install_cache.sh
99+
ENV PATH /opt/cache/bin:$PATH
100+
RUN bash ./install_cache.sh && rm install_cache.sh
101+
102+
# Include BUILD_ENVIRONMENT environment variable in image
103+
ARG BUILD_ENVIRONMENT
104+
ENV BUILD_ENVIRONMENT ${BUILD_ENVIRONMENT}
105+
106+
USER jenkins
107+
CMD ["bash"]

.circleci/docker/common/install_base.sh

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,14 +68,21 @@ install_ubuntu() {
6868
install_centos() {
6969
# Need EPEL for many packages we depend on.
7070
# See http://fedoraproject.org/wiki/EPEL
71-
yum --enablerepo=extras install -y epel-release
71+
# extras repo is not there for CentOS 9 and epel-release is already part of repo list
72+
if [[ $OS_VERSION == 9 ]]; then
73+
yum install -y epel-release
74+
ALLOW_ERASE="--allowerasing"
75+
else
76+
yum --enablerepo=extras install -y epel-release
77+
ALLOW_ERASE=""
78+
fi
7279

7380
ccache_deps="asciidoc docbook-dtds docbook-style-xsl libxslt"
7481
numpy_deps="gcc-gfortran"
7582
# Note: protobuf-c-{compiler,devel} on CentOS are too old to be used
7683
# for Caffe2. That said, we still install them to make sure the build
7784
# system opts to build/use protoc and libprotobuf from third-party.
78-
yum install -y \
85+
yum install -y $ALLOW_ERASE \
7986
$ccache_deps \
8087
$numpy_deps \
8188
autoconf \
@@ -93,22 +100,31 @@ install_centos() {
93100
glog-devel \
94101
hiredis-devel \
95102
libstdc++-devel \
96-
libsndfile-devel \
97103
make \
98-
opencv-devel \
99104
sudo \
100105
wget \
101106
vim
102107

108+
if [[ $OS_VERSION == 9 ]]
109+
then
110+
dnf --enablerepo=crb -y install libsndfile-devel
111+
else
112+
yum install -y \
113+
opencv-devel \
114+
libsndfile-devel
115+
fi
116+
103117
# Cleanup
104118
yum clean all
105119
rm -rf /var/cache/yum
106120
rm -rf /var/lib/yum/yumdb
107121
rm -rf /var/lib/yum/history
108122
}
109123

110-
# Install base packages depending on the base OS
111124
ID=$(grep -oP '(?<=^ID=).+' /etc/os-release | tr -d '"')
125+
OS_VERSION=$(grep -oP '(?<=^VERSION_ID=).+' /etc/os-release | tr -d '"')
126+
127+
# Install base packages depending on the base OS
112128
case "$ID" in
113129
ubuntu)
114130
install_ubuntu
@@ -123,7 +139,6 @@ case "$ID" in
123139
esac
124140

125141
# Install Valgrind separately since the apt-get version is too old.
126-
OS_VERSION=$(grep -oP '(?<=^VERSION_ID=).+' /etc/os-release | tr -d '"')
127142
if [[ $ID == centos && $OS_VERSION == 7 ]]; then WGET_FLAG="--no-check-certificate" ; else WGET_FLAG=""; fi
128143
mkdir valgrind_build && cd valgrind_build
129144
VALGRIND_VERSION=3.16.1

.circleci/docker/common/install_db.sh

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,23 @@ install_ubuntu() {
1818
install_centos() {
1919
# Need EPEL for many packages we depend on.
2020
# See http://fedoraproject.org/wiki/EPEL
21-
yum --enablerepo=extras install -y epel-release
21+
if [[ $OS_VERSION == 9 ]]; then
22+
yum install -y epel-release
23+
else
24+
yum --enablerepo=extras install -y epel-release
25+
fi
2226

2327
yum install -y \
2428
hiredis-devel \
25-
leveldb-devel \
26-
lmdb-devel \
27-
snappy-devel
29+
leveldb-devel
30+
31+
if [[ $OS_VERSION == 9 ]]; then
32+
dnf --enablerepo=crb -y install lmdb-devel snappy-devel
33+
else
34+
yum install -y \
35+
lmdb-devel \
36+
snappy-devel
37+
fi
2838

2939
# Cleanup
3040
yum clean all
@@ -33,6 +43,8 @@ install_centos() {
3343
rm -rf /var/lib/yum/history
3444
}
3545

46+
OS_VERSION=$(grep -oP '(?<=^VERSION_ID=).+' /etc/os-release | tr -d '"')
47+
3648
# Install base packages depending on the base OS
3749
ID=$(grep -oP '(?<=^ID=).+' /etc/os-release | tr -d '"')
3850
case "$ID" in

.circleci/docker/common/install_rocm.sh

Lines changed: 36 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -101,14 +101,24 @@ install_centos() {
101101
yum update -y
102102
yum install -y kmod
103103
yum install -y wget
104-
yum install -y openblas-devel
104+
105+
if [[ $OS_VERSION == 9 ]]; then
106+
dnf install -y openblas-serial
107+
dnf install -y dkms kernel-headers kernel-devel
108+
else
109+
yum install -y openblas-devel
110+
yum install -y dkms kernel-headers-`uname -r` kernel-devel-`uname -r`
111+
fi
105112

106113
yum install -y epel-release
107-
yum install -y dkms kernel-headers-`uname -r` kernel-devel-`uname -r`
108114

109115
if [[ $(ver $ROCM_VERSION) -ge $(ver 4.5) ]]; then
110116
# Add amdgpu repository
111-
local amdgpu_baseurl="https://repo.radeon.com/amdgpu/${AMDGPU_VERSIONS[$ROCM_VERSION]}/rhel/7.9/main/x86_64"
117+
if [[ $OS_VERSION == 9 ]]; then
118+
local amdgpu_baseurl="https://repo.radeon.com/amdgpu/${AMDGPU_VERSIONS[$ROCM_VERSION]}/rhel/9.0/main/x86_64"
119+
else
120+
local amdgpu_baseurl="https://repo.radeon.com/amdgpu/${AMDGPU_VERSIONS[$ROCM_VERSION]}/rhel/7.9/main/x86_64"
121+
fi
112122
echo "[AMDGPU]" > /etc/yum.repos.d/amdgpu.repo
113123
echo "name=AMDGPU" >> /etc/yum.repos.d/amdgpu.repo
114124
echo "baseurl=${amdgpu_baseurl}" >> /etc/yum.repos.d/amdgpu.repo
@@ -117,23 +127,40 @@ install_centos() {
117127
echo "gpgkey=http://repo.radeon.com/rocm/rocm.gpg.key" >> /etc/yum.repos.d/amdgpu.repo
118128
fi
119129

120-
local rocm_baseurl="http://repo.radeon.com/rocm/yum/${ROCM_VERSION}/main"
130+
if [[ $OS_VERSION == 9 ]]; then
131+
local rocm_baseurl="invalid-url"
132+
else
133+
local rocm_baseurl="http://repo.radeon.com/rocm/yum/${ROCM_VERSION}/main"
134+
fi
121135
echo "[ROCm]" > /etc/yum.repos.d/rocm.repo
122136
echo "name=ROCm" >> /etc/yum.repos.d/rocm.repo
123137
echo "baseurl=${rocm_baseurl}" >> /etc/yum.repos.d/rocm.repo
124138
echo "enabled=1" >> /etc/yum.repos.d/rocm.repo
125139
echo "gpgcheck=1" >> /etc/yum.repos.d/rocm.repo
126140
echo "gpgkey=http://repo.radeon.com/rocm/rocm.gpg.key" >> /etc/yum.repos.d/rocm.repo
127141

128-
yum update -y
129-
130-
yum install -y \
142+
if [[ $OS_VERSION == 9 ]]; then
143+
yum update -y --nogpgcheck
144+
dnf --enablerepo=crb install -y perl-File-BaseDir
145+
yum install -y --nogpgcheck rocm-ml-sdk rocm-developer-tools
146+
else
147+
yum update -y
148+
yum install -y \
131149
rocm-dev \
132150
rocm-utils \
133151
rocm-libs \
134152
rccl \
135153
rocprofiler-dev \
136154
roctracer-dev
155+
fi
156+
157+
# if search fails it will abort this script; use true to avoid case where search fails
158+
MIOPENKERNELS=$(yum -q search miopenkernels | grep miopenkernels- | awk '{print $1}'| grep -F kdb. || true)
159+
if [[ "x${MIOPENKERNELS}" = x ]]; then
160+
echo "miopenkernels package not available"
161+
else
162+
yum install -y ${MIOPENKERNELS}
163+
fi
137164

138165
# precompiled miopen kernels; search for all unversioned packages
139166
# if search fails it will abort this script; use true to avoid case where search fails
@@ -153,6 +180,8 @@ install_centos() {
153180
rm -rf /var/lib/yum/history
154181
}
155182

183+
OS_VERSION=$(grep -oP '(?<=^VERSION_ID=).+' /etc/os-release | tr -d '"')
184+
156185
# Install Python packages depending on the base OS
157186
ID=$(grep -oP '(?<=^ID=).+' /etc/os-release | tr -d '"')
158187
case "$ID" in

.circleci/docker/common/install_vision.sh

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,14 @@ install_ubuntu() {
1616
install_centos() {
1717
# Need EPEL for many packages we depend on.
1818
# See http://fedoraproject.org/wiki/EPEL
19-
yum --enablerepo=extras install -y epel-release
20-
21-
yum install -y \
22-
opencv-devel \
23-
ffmpeg-devel
19+
if [[ $OS_VERSION == 9 ]]; then
20+
yum install -y epel-release
21+
else
22+
yum --enablerepo=extras install -y epel-release
23+
yum install -y \
24+
opencv-devel \
25+
ffmpeg-devel
26+
fi
2427

2528
# Cleanup
2629
yum clean all
@@ -29,6 +32,8 @@ install_centos() {
2932
rm -rf /var/lib/yum/history
3033
}
3134

35+
OS_VERSION=$(grep -oP '(?<=^VERSION_ID=).+' /etc/os-release | tr -d '"')
36+
3237
# Install base packages depending on the base OS
3338
ID=$(grep -oP '(?<=^ID=).+' /etc/os-release | tr -d '"')
3439
case "$ID" in

0 commit comments

Comments
 (0)