Skip to content

Commit 02ee6fa

Browse files
committed
Cleaned up imports and removed unnecessary final keywords in the OperationThrottle class.
1 parent 77ac15b commit 02ee6fa

File tree

1 file changed

+9
-14
lines changed

1 file changed

+9
-14
lines changed

rxjava-core/src/main/java/rx/operators/OperationThrottle.java

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,8 @@
1515
*/
1616
package rx.operators;
1717

18-
import static org.mockito.Matchers.any;
19-
import static org.mockito.Matchers.anyString;
20-
import static org.mockito.Mockito.inOrder;
21-
import static org.mockito.Mockito.mock;
22-
import static org.mockito.Mockito.never;
23-
import static org.mockito.Mockito.times;
24-
import static org.mockito.Mockito.verify;
18+
import static org.mockito.Matchers.*;
19+
import static org.mockito.Mockito.*;
2520

2621
import java.util.concurrent.Executors;
2722
import java.util.concurrent.TimeUnit;
@@ -60,7 +55,7 @@ public final class OperationThrottle {
6055
* @param unit The unit of time for the specified timeout.
6156
* @return A {@link Func1} which performs the throttle operation.
6257
*/
63-
public static <T> Func1<Observer<T>, Subscription> throttle(final Observable<T> items, long timeout, TimeUnit unit) {
58+
public static <T> Func1<Observer<T>, Subscription> throttle(Observable<T> items, long timeout, TimeUnit unit) {
6459
return throttle(items, timeout, unit, Schedulers.executor(Executors.newSingleThreadScheduledExecutor()));
6560
}
6661

@@ -132,7 +127,7 @@ public void onError(Exception e) {
132127
}
133128

134129
@Override
135-
public void onNext(final T args) {
130+
public void onNext(T args) {
136131
throttle(new ThrottledOnNext<T>(observer, args));
137132
}
138133

@@ -215,7 +210,7 @@ public void before() {
215210
public void testThrottlingWithCompleted() {
216211
Observable<String> source = Observable.create(new Func1<Observer<String>, Subscription>() {
217212
@Override
218-
public Subscription call(final Observer<String> observser) {
213+
public Subscription call(Observer<String> observser) {
219214
publishNext(observser, 100, "one"); // Should be skipped since "two" will arrive before the timeout expires.
220215
publishNext(observser, 400, "two"); // Should be published since "three" will arrive after the timeout expires.
221216
publishNext(observser, 900, "four"); // Should be skipped since onCompleted will arrive before the timeout expires.
@@ -250,7 +245,7 @@ public Subscription call(final Observer<String> observser) {
250245
public void testThrottlingWithError() {
251246
Observable<String> source = Observable.create(new Func1<Observer<String>, Subscription>() {
252247
@Override
253-
public Subscription call(final Observer<String> observser) {
248+
public Subscription call(Observer<String> observser) {
254249
Exception error = new TestException();
255250
publishNext(observser, 100, "one"); // Should be published since "two" will arrive after the timeout expires.
256251
publishNext(observser, 600, "two"); // Should be skipped since onError will arrive before the timeout expires.
@@ -281,7 +276,7 @@ public Subscription call(final Observer<String> observser) {
281276
verify(observer, times(1)).onError(any(TestException.class));
282277
}
283278

284-
private void publishCompleted(final Observer<String> observer, long delay) {
279+
private <T> void publishCompleted(final Observer<T> observer, long delay) {
285280
scheduler.schedule(new Action0() {
286281
@Override
287282
public void call() {
@@ -290,7 +285,7 @@ public void call() {
290285
}, delay, TimeUnit.MILLISECONDS);
291286
}
292287

293-
private void publishError(final Observer<String> observer, long delay, final Exception error) {
288+
private <T> void publishError(final Observer<T> observer, long delay, final Exception error) {
294289
scheduler.schedule(new Action0() {
295290
@Override
296291
public void call() {
@@ -299,7 +294,7 @@ public void call() {
299294
}, delay, TimeUnit.MILLISECONDS);
300295
}
301296

302-
private void publishNext(final Observer<String> observer, long delay, final String value) {
297+
private <T> void publishNext(final Observer<T> observer, long delay, final T value) {
303298
scheduler.schedule(new Action0() {
304299
@Override
305300
public void call() {

0 commit comments

Comments
 (0)