Merge pull request #2622 from akarnokd/EmptyObservable

Changed Observable.empty() into a stateless constant observable.

Author: akarnokd

src/main/java/rx/Observable.java

@@ -15,13 +15,11 @@
 import java.util.*;
 import java.util.concurrent.*;
 
-import rx.annotations.Beta;
-import rx.annotations.Experimental;
+import rx.annotations.*;
 import rx.exceptions.*;
 import rx.functions.*;
 import rx.internal.operators.*;
-import rx.internal.util.ScalarSynchronousObservable;
-import rx.internal.util.UtilityFunctions;
+import rx.internal.util.*;
 import rx.observables.*;
 import rx.observers.SafeSubscriber;
 import rx.plugins.*;
@@ -1031,6 +1029,14 @@ public final static <T> Observable<T> defer(Func0<Observable<T>> observableFacto
         return create(new OnSubscribeDefer<T>(observableFactory));
     }
 
+    /** An empty observable which just emits onCompleted to any subscriber. */
+    private static final Observable<Object> EMPTY = create(new OnSubscribe<Object>() {
+        @Override
+        public void call(Subscriber<? super Object> t1) {
+            t1.onCompleted();
+        }
+    });
+    
     /**
      * Returns an Observable that emits no items to the {@link Observer} and immediately invokes its
      * {@link Observer#onCompleted onCompleted} method.
@@ -1047,8 +1053,9 @@ public final static <T> Observable<T> defer(Func0<Observable<T>> observableFacto
      *         {@link Observer}'s {@link Observer#onCompleted() onCompleted} method
      * @see <a href="http://reactivex.io/documentation/operators/empty-never-throw.html">ReactiveX operators documentation: Empty</a>
      */
+    @SuppressWarnings("unchecked")
     public final static <T> Observable<T> empty() {
-        return from(Collections.<T>emptyList());
+        return (Observable<T>)EMPTY;
     }
 
     /**

src/test/java/rx/ObservableTests.java

@@ -1116,4 +1116,17 @@ public void testErrorThrownIssue1685() {
         System.out.println("Done");
     }
 
+    @Test
+    public void testEmptyIdentity() {
+        assertEquals(Observable.empty(), Observable.empty());
+    }
+    
+    @Test
+    public void testEmptyIsEmpty() {
+        Observable.<Integer>empty().subscribe(w);
+        
+        verify(w).onCompleted();
+        verify(w, never()).onNext(any(Integer.class));
+        verify(w, never()).onError(any(Throwable.class));
+    }
 }